Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug for LoadAxis on BarPointLoad and BarVaryingLoad #368

Merged
merged 6 commits into from
Sep 13, 2023

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Sep 13, 2023

Issues addressed by this PR

Closes #367

Test files

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/Lusas_Toolkit/%23367%20LoadsPulledAsGlobal.gh?csf=1&web=1&e=IBUOdT

Changelog

  • Fixed a bug where BarPointLoads were being defaulted to LoadAxis.Global when pulled, despite appearing in Lusas correctly;
  • Fixed a bug where BarVaryingLoads were being to defaulted to LoadAxis.Global and Projected = false despite appearing in Lusas correctly;
  • Updated the error message when a user tries to push BarVaryingLoad that has Projected = true and RelativeDistance = false - this combination is still unsupported;
  • Updated warning for BarVaryingLoad to warn against non-parametric distances used when relevant (i.e. `RelativeDistance = false"
  • Added warning for v19 and prior for BarVaryingLoad defaulting to Global and false projected

Additional comments

@peterjamesnugent peterjamesnugent added the type:bug Error or unexpected behaviour label Sep 13, 2023
@peterjamesnugent peterjamesnugent self-assigned this Sep 13, 2023
@peterjamesnugent
Copy link
Member Author

@BHoMBot check required
@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 13, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check copyright-compliance

…ning because load axis and projected loads are not correctly read (i.e. always Global and not projected)
…ning because load axis and projected loads are not correctly read (i.e. always Global and not projected)
KalleEdstroem
KalleEdstroem previously approved these changes Sep 13, 2023
Copy link
Contributor

@KalleEdstroem KalleEdstroem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script works as intended.
New error text appears.
Checked values in the script were correct.

@peterjamesnugent peterjamesnugent dismissed KalleEdstroem’s stale review September 13, 2023 13:41

About to push some additional code for Lsuas v17-v19 where the "LoadDirection" values are unsupported

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required
@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 13, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check copyright-compliance

Copy link
Contributor

@KalleEdstroem KalleEdstroem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script worked as intended.
Checks in the script were correct.
Error message was correctly shown for not supported combinations.
Checks performed with LusasV200Adapter

@peterjamesnugent
Copy link
Member Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 13, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer

There are 1 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 13, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 13, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check ready-to-merge

There are 1 requests in the queue ahead of you.

@peterjamesnugent peterjamesnugent merged commit 14c70f3 into develop Sep 13, 2023
10 checks passed
@peterjamesnugent peterjamesnugent deleted the Lusas_Toolkit-#367-LoadsPulledAsGlobal branch September 13, 2023 15:23
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loads being pulled as Global but pushed as Local
2 participants