-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug for LoadAxis on BarPointLoad and BarVaryingLoad #368
Fixed bug for LoadAxis on BarPointLoad and BarVaryingLoad #368
Conversation
@peterjamesnugent to confirm, the following actions are now queued:
|
…ning because load axis and projected loads are not correctly read (i.e. always Global and not projected)
…ning because load axis and projected loads are not correctly read (i.e. always Global and not projected)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script works as intended.
New error text appears.
Checked values in the script were correct.
About to push some additional code for Lsuas v17-v19 where the "LoadDirection" values are unsupported
@peterjamesnugent to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script worked as intended.
Checks in the script were correct.
Error message was correctly shown for not supported combinations.
Checks performed with LusasV200Adapter
@BHoMBot check installer |
@peterjamesnugent to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
The check |
@BHoMBot check ready-to-merge |
@peterjamesnugent to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #367
Test files
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/Lusas_Toolkit/%23367%20LoadsPulledAsGlobal.gh?csf=1&web=1&e=IBUOdT
Changelog
BarPointLoad
s were being defaulted toLoadAxis.Global
when pulled, despite appearing in Lusas correctly;BarVaryingLoad
s were being to defaulted toLoadAxis.Global
andProjected = false
despite appearing in Lusas correctly;BarVaryingLoad
that hasProjected = true
andRelativeDistance = false
- this combination is still unsupported;BarVaryingLoad
to warn against non-parametric distances used when relevant (i.e. `RelativeDistance = false"BarVaryingLoad
defaulting toGlobal
andfalse
projectedAdditional comments