Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Adapter for Lusas v20.0 #359

Merged
merged 5 commits into from
Jul 13, 2023

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Jun 29, 2023

Issues addressed by this PR

Closes #358

Test files

Push and pull elements, properties and tags
Push and Pull Loads

Changelog

Added adapter functionality for Lusas 20.0

Additional comments

I have tested this on Lusas v20.0-3, but should work for 20.0-0 to 20.0-3.

@peterjamesnugent peterjamesnugent added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Jun 29, 2023
@peterjamesnugent peterjamesnugent self-assigned this Jun 29, 2023
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR title to be appropriate @peterjamesnugent . Also can you add an altConfigs.txt file so the bot knows there's multiple configs to check when running checks on this repo.
See an example on Revit_Toolkit here 😄

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 30, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 30, 2023

@peterjamesnugent fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 14679014685

@peterjamesnugent
Copy link
Member Author

@BHoMBot fix project file ref. 14679014685

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 30, 2023

@peterjamesnugent I have queued up your request to fix the csproj file(s). There are 0 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 30, 2023

@peterjamesnugent I am now going to fix the project compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 30, 2023

@peterjamesnugent to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 30, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check project-compliance

@peterjamesnugent peterjamesnugent changed the title Lusas toolkit 358 upgrade adapter for lusas20 Upgrade Adapter for Lusas v20.0 Jul 4, 2023
@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 6, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 23 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 6, 2023

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@StephennipBH StephennipBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see below screenshot for the question on mesh setting 2d split 2d size
image

@peterjamesnugent
Copy link
Member Author

@StephennipBH that was an issue with the script, the length parameters was not plugged in to the right input. I have updated the script and tested:
image

@StephennipBH StephennipBH self-requested a review July 13, 2023 08:19
@StephennipBH StephennipBH self-requested a review July 13, 2023 08:19
Copy link
Contributor

@StephennipBH StephennipBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted that it's a small error in the test script rather than component functionality, therefore approved

@peterjamesnugent
Copy link
Member Author

@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 13, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check copyright-compliance
  • check ready-to-merge

@peterjamesnugent peterjamesnugent merged commit 817f54b into develop Jul 13, 2023
@peterjamesnugent peterjamesnugent deleted the Lusas_Toolkit-358-UpgradeAdapterForLusas20 branch July 13, 2023 08:26
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Adapter for Lusas 20.0
4 participants