-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Adapter for Lusas v20.0 #359
Upgrade Adapter for Lusas v20.0 #359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PR title to be appropriate @peterjamesnugent . Also can you add an altConfigs.txt
file so the bot knows there's multiple configs to check when running checks on this repo.
See an example on Revit_Toolkit here 😄
@BHoMBot check required |
@peterjamesnugent to confirm, the following actions are now queued:
|
@peterjamesnugent fix requested for project compliance. The errors with the CSProject ( I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with:
|
@BHoMBot fix project file ref. 14679014685 |
@peterjamesnugent I have queued up your request to fix the |
@peterjamesnugent I am now going to fix the project compliance in accordance with the annotations previously made. |
@peterjamesnugent to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request. |
@BHoMBot check project-compliance |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check required |
@peterjamesnugent to confirm, the following actions are now queued:
There are 23 requests in the queue ahead of you. |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StephennipBH that was an issue with the script, the length parameters was not plugged in to the right input. I have updated the script and tested: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted that it's a small error in the test script rather than component functionality, therefore approved
@peterjamesnugent to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #358
Test files
Push and pull elements, properties and tags
Push and Pull Loads
Changelog
Added adapter functionality for Lusas 20.0
Additional comments
I have tested this on Lusas v20.0-3, but should work for 20.0-0 to 20.0-3.