Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add altConfig for Lusas200 #186

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

peterjamesnugent
Copy link
Member

NOTE: Depends on

BHoM/Lusas_Toolkit#359

Issues addressed by this PR

Closes #185

Test files

Changelog

Additional comments

@peterjamesnugent peterjamesnugent added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Jun 30, 2023
@peterjamesnugent peterjamesnugent self-assigned this Jun 30, 2023
@peterjamesnugent
Copy link
Member Author

@BHoMBot run copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 30, 2023

@peterjamesnugent sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 30, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check copyright-compliance

There are 9 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 30, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer

There are 2 requests in the queue ahead of you.

Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should be rebased to the latest main, owing to the following change being introduced:

  • All included repositories are now housed in a folder called IncludedRepos to tidy up the repository
  • This has included altConfigs.txt which this PR is modifying

A rebase should be sufficient hopefully, though the change may need to be made to the new file but hopefully not.

@FraserGreenroyd FraserGreenroyd force-pushed the Lusas_Toolkit-358-UpgradeAdapterForLusas20 branch from ad1467c to 30936d1 Compare July 3, 2023 20:05
@FraserGreenroyd FraserGreenroyd added type:feature New capability or enhancement and removed type:external-api-changes Imposed changes, including from dependency across other BHoM repos labels Jul 3, 2023
@peterjamesnugent
Copy link
Member Author

@BHoMBot check copyright-compliance
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 13, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check copyright-compliance
  • check installer

@FraserGreenroyd
Copy link

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 13, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lusas PR has been merged so merging this to deploy.

@FraserGreenroyd FraserGreenroyd merged commit 0b40fd5 into main Jul 13, 2023
@FraserGreenroyd FraserGreenroyd deleted the Lusas_Toolkit-358-UpgradeAdapterForLusas20 branch July 13, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add altConfig for Lusas200
2 participants