Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for EPWToCSV #145

Merged
merged 5 commits into from
Nov 24, 2023
Merged

Fix for EPWToCSV #145

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e30c01f
fixed incorrect file extension
Tom-Kingstone Nov 15, 2023
d45dd9b
now returns null when file conversion failed, rather than a path to a…
Tom-Kingstone Nov 15, 2023
ecacc2f
fixed incorrect file extension
Tom-Kingstone Nov 15, 2023
0a3b955
now returns null when file conversion failed, rather than a path to a…
Tom-Kingstone Nov 15, 2023
4df647e
Merge branch 'LadybugTools_Toolkit-#140-EPWtoCSV' of https://github.c…
Tom-Kingstone Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion LadybugTools_Engine/Compute/EPWtoCSV.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public static string EPWtoCSV(string epwFile, bool includeAdditional = false)
PythonEnvironment env = InstallPythonEnv_LBT(true);

epwFile = System.IO.Path.GetFullPath(epwFile);
string csvFile = System.IO.Path.ChangeExtension(epwFile, ".hbjson");
string csvFile = System.IO.Path.ChangeExtension(epwFile, ".csv");

string script = Path.Combine(Python.Query.DirectoryCode(), "LadybugTools_Toolkit\\src\\ladybugtools_toolkit\\bhom\\wrapped", "epw_to_csv.py");

Expand All @@ -62,6 +62,7 @@ public static string EPWtoCSV(string epwFile, bool includeAdditional = false)
if (!File.Exists(csvFile))
{
BH.Engine.Base.Compute.RecordError($"File conversion failed due to {result}");
return null;
}

return csvFile;
Expand Down