-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for EPWToCSV #145
Fix for EPWToCSV #145
Conversation
… nonexistent file.
… nonexistent file.
…om/BHoM/LadybugTools_Toolkit into LadybugTools_Toolkit-#140-EPWtoCSV
@Tom-Kingstone to confirm, the following actions are now queued:
|
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aligns with discussion, happy to approve
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@BHoMBot check ready-to-merge |
@Tom-Kingstone to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #140
Fixed EPWtoCSV trying to find a .hbjson file instead of a csv.
Also fixed returning a path when file conversion fails, as there would be no file or a corrupt file if it failed.
Test files
Try running EPWToCSV and see that the error does not occur any more.
Changelog
Additional comments