Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.2 Deployment #190

Merged
merged 4 commits into from
Jun 20, 2024
Merged

7.2 Deployment #190

merged 4 commits into from
Jun 20, 2024

Conversation

@michaelhoehn michaelhoehn added the type:feature New capability or enhancement label Jun 10, 2024
@michaelhoehn
Copy link

@BHoMBot check compliance

Copy link
Author

bhombot-ci bot commented Jun 17, 2024

@michaelhoehn to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 112 requests in the queue ahead of you.

@michaelhoehn
Copy link

@BHoMBot check serialisation
@BHoMBot check null-handling

Copy link
Author

bhombot-ci bot commented Jun 17, 2024

@michaelhoehn to confirm, the following actions are now queued:

  • check serialisation
  • check null-handling

There are 299 requests in the queue ahead of you.

@alelom alelom self-requested a review June 17, 2024 15:12
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, although it seems we lost the "extra" functionality (not used anywhere, AFAIK, as stated in the testing procedure) of pulling formatted JSON. Raised #191.

Copy link
Author

bhombot-ci bot commented Jun 19, 2024

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

Copy link
Author

bhombot-ci bot commented Jun 20, 2024

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@IsakNaslundBh
Copy link
Contributor

IsakNaslundBh commented Jun 20, 2024

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core

Copy link
Author

bhombot-ci bot commented Jun 20, 2024

@IsakNaslundBh I'm sorry, but I am not authorised to take that instruction from you.

Copy link
Author

bhombot-ci bot commented Jun 20, 2024

@IsakNaslundBh I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link
Author

bhombot-ci bot commented Jun 20, 2024

@bhombot-ci[bot] just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on Excel_UI

@al-fisher al-fisher merged commit 50a8aa2 into main Jun 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants