Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Documentation and Code compliance #183

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

Tom-Kingstone
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #

added some method separators as well

Test files

Changelog

Additional comments

@Tom-Kingstone Tom-Kingstone added the type:compliance Non-conforming to code guidelines label Mar 26, 2024
@Tom-Kingstone Tom-Kingstone self-assigned this Mar 26, 2024
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Mar 26, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Mar 26, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 8 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Mar 26, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Mar 26, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Mar 26, 2024

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Mar 26, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Mar 26, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning

There are 16 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Mar 26, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning

There are 20 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Mar 26, 2024

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer
@BHoMBot check null-handling
@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Mar 26, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer
  • check null-handling
  • check serialisation

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks @Tom-Kingstone

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Mar 26, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Mar 26, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 0d41d28 into develop Mar 26, 2024
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the File_Toolkit-#182-MakeExtensionMethods branch March 26, 2024 20:25
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants