Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioning for ExcelPushConfig #6

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Conversation

FraserGreenroyd
Copy link

Fixes an issue with versioning from #5 which was missed by the bot.

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Oct 26, 2022
@FraserGreenroyd FraserGreenroyd self-assigned this Oct 26, 2022
@FraserGreenroyd
Copy link
Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 26, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 26, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 26, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 26, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 26, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 27, 2022

@FraserGreenroyd just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on RFEM_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 27, 2022

@FraserGreenroyd just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on RFEM_Toolkit

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PreviousVersion attributes correctly applied. Approved

@IsakNaslundBh IsakNaslundBh merged commit 2e1645b into main Oct 27, 2022
@IsakNaslundBh IsakNaslundBh deleted the FixVersioning-53 branch October 27, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants