Improving adapter functionality

[adecler]

NOTE: Depends on

BHoM/BHoM_Engine#2919
This is not a direct dependency (the code compiles fine without it) but this other PR solves a bug with the SetProperty component that happens in the test file.

Issues addressed by this PR

Closes #4

• Assessing current state of the adapter and time needed to improve
• Ability to pull from the file when it is open
• If no range/sheet is specified in pull -> full content of first sheet
• DataTable is very confusing to use in GH -> need to either improve its support in BHoM or replace it
• Ability to pull a list of list instead of a DataTable
• Ability to pull a list of CustomObjects where firs row gives the property names
• Ability to specify the type of objects to pull

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/Eo50MIUFAS5CqkhUyfiG6PABSQBkm5R_gokTu0eGeoNxRA?e=JPFp2N

Additional comments

• I have tried various solutions to enable to push to a file already opened in Excel but it seems that the file is properly locked by Excel for writing.
• There is a lot more that can be done in the push but this is outside of the scope of this PR as the main focus was to get a pulling properly working. Once we have more user cases for the Push, I am happy to do another wave of development specifically around that. Right now, the main issue was to remove the need to use the DataTable.
• Right now, the support for objects is purely limited to top level properties. Deep property explode with multi-line headers can be added in a separate PR if there is a need for non-flat structures.

[adecler]

@BHoMBot check compliance
@BHoMBot check versioning

[bhombot-ci]

@adecler to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check versioning

There are 15 requests in the queue ahead of you.

[IsakNaslundBh]

Generally working really well, and a nice improvement, both for push and pull.

Have left 2 comments below (one typo and one slight functional tweak).

[adecler]

@BHoMBot check compliance
@BHoMBot check versioning

[bhombot-ci]

@adecler to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check versioning

[IsakNaslundBh]

Tested with provided test script, and works fine.

Reading the "Additional coomments" I do agree that that is out of scope for this PR, and this is a great step forward.

From code review, looks good.

Approved!

[adecler]

@BHoMBot check compliance
@BHoMBot check versioning

[bhombot-ci]

@adecler to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check versioning

There are 4 requests in the queue ahead of you.

[adecler]

@BHoMBot check required

[bhombot-ci]

@adecler to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

There are 13 requests in the queue ahead of you.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.