-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versioning_Engine: Adding lock around the upgrader loop in the ToNewVersion method. #2941
Versioning_Engine: Adding lock around the upgrader loop in the ToNewVersion method. #2941
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes are sensible and resolves the issue described.
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 12 requests in the queue ahead of you. |
@BHoMBot check required |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 40 requests in the queue ahead of you. |
The check |
1 similar comment
@FraserGreenroyd to confirm, the following actions are now queued:
|
@FraserGreenroyd to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
The check |
The check |
FAO: @FraserGreenroyd The check they wish to have dispensation on is code-compliance. If you are providing dispensation on this occasion, please reply with:
|
FAO: @FraserGreenroyd The check they wish to have dispensation on is documentation-compliance. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 9276168902 |
@FraserGreenroyd I have now provided a passing check on reference |
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 9276173070 |
@FraserGreenroyd I have now provided a passing check on reference |
Issues addressed by this PR
Closes #2940
Adding a simple lock around the for loop calling the BHoMUpgraders in attempt to make it thread safe.
Simplest way of dealing with this that I could think of, but open for this to be handled differently if a better way is suggested.
Test files
Hard to provide. To test, one can ensure to have analytics logs with methods requiring versioning (or failing to deserialise for other reasons) while opening a script requiring versioning.
Changelog
Additional comments