Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning_Engine: ToNewVersion is not thread safe #2940

Closed
IsakNaslundBh opened this issue Nov 3, 2022 · 0 comments · Fixed by #2941
Closed

Versioning_Engine: ToNewVersion is not thread safe #2940

IsakNaslundBh opened this issue Nov 3, 2022 · 0 comments · Fixed by #2941
Assignees
Labels
type:bug Error or unexpected behaviour

Comments

@IsakNaslundBh
Copy link
Contributor

Description:

The ToNewVersion method is not thread safe which can lead to race conditions that currently are not handled. Issue can present itself when for example analytics is run at the same time as opening a script that have failures in deserialisation leading to versioning being called.

Steps to reproduce:

Make sure you have analytics logs requiring versioning and try open a script requiring versioning.

Expected behaviour:

For processes to not cause race conditions leading to UI hanging.

First suggestion is to put a simple padlock around the calls to the BHoMUpgrader via pipes in the ToNewVersion method.

Test file(s):

@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Nov 3, 2022
@IsakNaslundBh IsakNaslundBh self-assigned this Nov 3, 2022
@IsakNaslundBh IsakNaslundBh changed the title Versioning_Toolkit: ToNewVersion is not thread safe Versioning_Engine: ToNewVersion is not thread safe Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant