Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for release builds and consolidate NuGet packages #147

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

philnach
Copy link
Contributor

This change address issue #146 and consolidates all NuGet packages to the same versions.

Changes:

  1. Cosmos.DataTransfer.Interfaces.csproj referenced version 6.0.0.0 of Microsoft.Extensions.Logging.Abstractions, which was causing the load failure. Updating to version 8.0.0.0 resolves the issue.
  2. Visual Studio package manager for the solution suggested a number of NuGet packages that could be consolidated. This change gets everything on the same version.

How tested:

  1. Tested successful source: cosmos-nosql -> sink: Json-AzureBlob via command line
  2. Ran GitHub Action for generating packages: https://github.com/philnach/data-migration-desktop-tool/actions/runs/11045214931
  3. Verified windows-package runs successfully without error from command line
  4. Ran unit tests and confirmed the all passed: https://github.com/philnach/data-migration-desktop-tool/actions/runs/11045455482

@philnach
Copy link
Contributor Author

@bowencode any chance you can take a look at this and release a new version of the DMT with this change? I believe updating the release will also address #143 by just the libraries being updated.

@bowencode bowencode merged commit 574cf77 into AzureCosmosDB:main Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants