Conditionally Target NET 9 #2739

FuPingFranco · 2024-04-01T22:09:44Z

Add a net 9 target to Id Web with conditional compilation.

Successful Builds:

TargetNet9 = True (https://identitydivision.visualstudio.com/IDDP/_build/results?buildId=1281414&view=results)

TargetNet9 = False (https://identitydivision.visualstudio.com/IDDP/_build/results?buildId=1281375&view=results)

tests/E2E Tests/WebAppUiTests/WebAppUiTests.csproj

...oft.Identity.Web.GraphServiceClientBeta/Microsoft.Identity.Web.GraphServiceClientBeta.csproj

src/Microsoft.Identity.Web.TokenAcquisition/Microsoft.Identity.Web.TokenAcquisition.csproj

src/Microsoft.Identity.Web.TokenCache/Microsoft.Identity.Web.TokenCache.csproj

tests/Microsoft.Identity.Web.Test/Microsoft.Identity.Web.Test.csproj

…csproj Co-authored-by: Westin Musser <[email protected]>

…okenCache.csproj Co-authored-by: Westin Musser <[email protected]>

….Web.TokenAcquisition.csproj Co-authored-by: Westin Musser <[email protected]>

jmprieur

There is no Net9 target for Microsoft.Identity.Web.UI

.github/workflows/dotnetcore.yml

Directory.Build.props

src/Microsoft.Identity.Web.TokenAcquisition/Microsoft.Identity.Web.TokenAcquisition.csproj

src/Microsoft.Identity.Web.TokenCache/Microsoft.Identity.Web.TokenCache.csproj

tests/DevApps/Directory.Build.props

jennyf19

after addressing the comments, please run this command:
dotnet msbuild .\Microsoft.Identity.Web.sln -p:v=m and see if things are looking good.

FuPingFranco · 2024-04-04T22:56:59Z

@jennyf19 , I can only run msbuild Microsoft.Identity.Web.sln /p:v=m /p:TargetNet9=True at the moment since using dotnet bring the OWIN apps error. I ran the msbuild command and everything looks fine. I got a warning that I will address on a separate PR but not an issue to complete this PR.

src/Microsoft.Identity.Web.TokenAcquisition/Microsoft.Identity.Web.TokenAcquisition.csproj

jennyf19

Directory.Build.props

src/Microsoft.Identity.Web.GraphServiceClient/Microsoft.Identity.Web.GraphServiceClient.csproj

tests/Microsoft.Identity.Web.Test/WebAppExtensionsTests.cs

jmprieur

I left a few questions.

Directory.Build.props

Co-authored-by: Peter <[email protected]>

src/Microsoft.Identity.Web.TokenAcquisition/Microsoft.Identity.Web.TokenAcquisition.csproj

Addressed by adding NET 9 target in Microsoft.Identity.Web.UI

Franco Fung and others added 12 commits March 29, 2024 15:29

Test target NET9 preview

361c7a5

Fix NU1102's

7b574c1

Move directive condition for Skipping failining test

8d0d2f9

Fix app-provioning tool condition

8b05b39

Fix Typo

5868b14

Merge branch 'master' into francofung/TryTargetNet9

45a1bd3

Try fix test

bb3b32f

Undo unit test fix

008c119

Increase Time out

2ad9fa8

Revert timeout test change

fe16eb2

Do not target net 9 in daemon apps

c0e02d7

Add NET 9 condition to failing test

b63e110

FuPingFranco changed the title ~~[Do Not Merge] Test Github Action with Net 9~~ Conditionally Target NET 9 Apr 2, 2024

FuPingFranco marked this pull request as ready for review April 2, 2024 21:35

FuPingFranco commented Apr 2, 2024

View reviewed changes

tests/E2E Tests/WebAppUiTests/WebAppUiTests.csproj Show resolved Hide resolved

FuPingFranco linked an issue Apr 2, 2024 that may be closed by this pull request

[Feature Request] conditionally target .NET9-preview #2702

Closed

keegan-caruso reviewed Apr 2, 2024

View reviewed changes

...oft.Identity.Web.GraphServiceClientBeta/Microsoft.Identity.Web.GraphServiceClientBeta.csproj Outdated Show resolved Hide resolved

keegan-caruso reviewed Apr 2, 2024

View reviewed changes

src/Microsoft.Identity.Web.TokenAcquisition/Microsoft.Identity.Web.TokenAcquisition.csproj Outdated Show resolved Hide resolved

westin-m reviewed Apr 2, 2024

View reviewed changes

src/Microsoft.Identity.Web.TokenAcquisition/Microsoft.Identity.Web.TokenAcquisition.csproj Outdated Show resolved Hide resolved

westin-m reviewed Apr 2, 2024

View reviewed changes

src/Microsoft.Identity.Web.TokenCache/Microsoft.Identity.Web.TokenCache.csproj Show resolved Hide resolved

westin-m reviewed Apr 2, 2024

View reviewed changes

tests/Microsoft.Identity.Web.Test/Microsoft.Identity.Web.Test.csproj Show resolved Hide resolved

FuPingFranco and others added 3 commits April 2, 2024 15:08

Update tests/Microsoft.Identity.Web.Test/Microsoft.Identity.Web.Test.…

5d164d4

…csproj Co-authored-by: Westin Musser <[email protected]>

Update src/Microsoft.Identity.Web.TokenCache/Microsoft.Identity.Web.T…

d42b6fb

…okenCache.csproj Co-authored-by: Westin Musser <[email protected]>

Update src/Microsoft.Identity.Web.TokenAcquisition/Microsoft.Identity…

a1e6c32

….Web.TokenAcquisition.csproj Co-authored-by: Westin Musser <[email protected]>

jmprieur previously requested changes Apr 3, 2024

View reviewed changes

.github/workflows/dotnetcore.yml Outdated Show resolved Hide resolved

jennyf19 reviewed Apr 3, 2024

View reviewed changes

Directory.Build.props Outdated Show resolved Hide resolved

jennyf19 reviewed Apr 3, 2024

View reviewed changes

src/Microsoft.Identity.Web.TokenAcquisition/Microsoft.Identity.Web.TokenAcquisition.csproj Outdated Show resolved Hide resolved

jennyf19 reviewed Apr 3, 2024

View reviewed changes

src/Microsoft.Identity.Web.TokenCache/Microsoft.Identity.Web.TokenCache.csproj Outdated Show resolved Hide resolved

jennyf19 reviewed Apr 3, 2024

View reviewed changes

tests/DevApps/Directory.Build.props Outdated Show resolved Hide resolved

jennyf19 requested changes Apr 3, 2024

View reviewed changes

Franco Fung added 3 commits April 3, 2024 10:43

Address PR feedback

075c52d

Un-Target Net 9 for flaky test

5e3219c

Use var to control Net 9 versions

d29c304

keegan-caruso reviewed Apr 4, 2024

View reviewed changes

src/Microsoft.Identity.Web.TokenAcquisition/Microsoft.Identity.Web.TokenAcquisition.csproj Outdated Show resolved Hide resolved

Franco Fung and others added 3 commits April 4, 2024 16:31

Test using TargetFrameworkIdentifier condition

b0bc0ff

Merge branch 'master' into francofung/TryTargetNet9

4e39241

Merge branch 'master' into francofung/TryTargetNet9

fd91124

jennyf19 approved these changes Apr 5, 2024

View reviewed changes

jmprieur reviewed Apr 5, 2024

View reviewed changes

Directory.Build.props Outdated Show resolved Hide resolved

jmprieur reviewed Apr 5, 2024

View reviewed changes

src/Microsoft.Identity.Web.GraphServiceClient/Microsoft.Identity.Web.GraphServiceClient.csproj Show resolved Hide resolved

jmprieur reviewed Apr 5, 2024

View reviewed changes

tests/Microsoft.Identity.Web.Test/WebAppExtensionsTests.cs Show resolved Hide resolved

jmprieur reviewed Apr 5, 2024

View reviewed changes

pmaytak reviewed Apr 5, 2024

View reviewed changes

Directory.Build.props Outdated Show resolved Hide resolved

Update Directory.Build.props

448a6a0

Co-authored-by: Peter <[email protected]>

pmaytak reviewed Apr 5, 2024

View reviewed changes

src/Microsoft.Identity.Web.TokenAcquisition/Microsoft.Identity.Web.TokenAcquisition.csproj Show resolved Hide resolved

pmaytak approved these changes Apr 5, 2024

View reviewed changes

FuPingFranco merged commit e82a525 into master Apr 5, 2024
5 checks passed

FuPingFranco deleted the francofung/TryTargetNet9 branch April 5, 2024 23:29

FuPingFranco self-assigned this May 30, 2024

FuPingFranco mentioned this pull request Jun 4, 2024

Update to Latest NET9 Preview #2877

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Conditionally Target NET 9 #2739

Conditionally Target NET 9 #2739

FuPingFranco commented Apr 1, 2024 •

edited

Loading

jmprieur left a comment

jennyf19 left a comment

FuPingFranco commented Apr 4, 2024 •

edited

Loading

jennyf19 left a comment

jmprieur left a comment

Conditionally Target NET 9 #2739

Conditionally Target NET 9 #2739

Conversation

FuPingFranco commented Apr 1, 2024 • edited Loading

jmprieur left a comment

Choose a reason for hiding this comment

jennyf19 left a comment

Choose a reason for hiding this comment

FuPingFranco commented Apr 4, 2024 • edited Loading

jennyf19 left a comment

Choose a reason for hiding this comment

jmprieur left a comment

Choose a reason for hiding this comment

FuPingFranco commented Apr 1, 2024 •

edited

Loading

FuPingFranco commented Apr 4, 2024 •

edited

Loading