Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] conditionally target .NET9-preview #2702

Closed
jennyf19 opened this issue Mar 14, 2024 · 1 comment · Fixed by #2739
Closed

[Feature Request] conditionally target .NET9-preview #2702

jennyf19 opened this issue Mar 14, 2024 · 1 comment · Fixed by #2739
Assignees

Comments

@jennyf19
Copy link
Collaborator

jennyf19 commented Mar 14, 2024

see this .NET8-preview PR as an example of what to do

https://github.com/AzureAD/microsoft-identity-web/pull/2318/files

Make sure the .NET9-preview is added to the GitHub action and the right builds. We should also have a build variable for .NET 9

start with 9.0.100-preview.2.24157.14
https://dotnet.microsoft.com/en-us/download/dotnet/9.0 and we'll update it every month. Using a * does not work well in this case.

@jmprieur
Copy link
Collaborator

jmprieur commented Mar 14, 2024

An even better condition to add the new target framework is to modify <TargetFrameworks> conditionally (adding the line in green below)

<TargetFrameworks>net6.0; net7.0; net8.0; net462; net472; netstandard2.0</TargetFrameworks>
+ <TargetFrameworks Condition="'$(TargetNet9)'== 'True'">$(TargetFrameworks); net9.0</TargetFrameworks>

@FuPingFranco FuPingFranco linked a pull request Apr 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants