Jmprieur/related to249 #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennyf19
reviewed
Jun 29, 2020
pmaytak
approved these changes
Jun 29, 2020
Co-authored-by: jennyf19 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is there to prepare the work on #249 which consists in removing the TokenAcquisitionSingleton property from the Microsoft.Identity.Options (and the associated management and tests). AddMicrosoftWebAppCallsWebApi / AddMicrosoftWebApiCallsWebApi would systematically do AddTokenAcquisition(), which means AddTokenAcquisition(false), as this the default value is false.
The solution below consists in having
AddMicrosoftGraphcall directlyAddTokenAcquisition(true)(to set it up as a singleton), instead of having the user to specify a different option in the config file, which s/he could forget to do, and would require more documentation. ThenAddTokenAcquisition()removes the previous service and readds it, if needed, with the right lifetime.The last call to
AddTokenAcquisition()wins. Therefore the call toAddMicrosoftGraphneeds to happen after the calls to AddMicrosoftWebAppCallsWebApi / AddMicrosoftWebApiCallsWebApi