[Bug] SingletonTokenAcquisition can be removed

[jmprieur]

Which Version of Microsoft Identity Web are you using ?
Microsoft Identity Web 0.1.5-preview

AddTokenAcquisition isTokenAcquisitionSingleton parameter (never used)

microsoft-identity-web/src/Microsoft.Identity.Web/ServiceCollectionExtensions.cs

Lines 32 to 34 in 0b628e2

	public static IServiceCollection AddTokenAcquisition(
	this IServiceCollection services,
	bool isTokenAcquisitionSingleton = false)

is a request from the Microsoft Graph SDK which want a singleton (whereas in general that’s not such a good idea)

See https://github.com/AzureAD/microsoft-identity-web/blob/master/tests/WebAppCallsMicrosoftGraph/appsettings.json#L9

There is an alternative which is that the GraphService registers the ITokenAcquisition as a singleton (the last which does the registration)

Decision:

• We keep AddTokenAcquisition as is
• We remove the SingletonTokenAcquisition property from the Microsoft.Identity.Options
• AddTokenAcquision is called with the default value (false) from the extension methods
• Remove the tests that were testing this.

[jennyf19]

Included in 0.2.0-preview release

[sviatoslav-vilkovych]

So, there is no more posibility to have TokenAcquisition registered as a Singleton service, right?

[pmaytak]

You still can. Call services.AddTokenAcquisition(true) at the end of ConfigureServices method. (The related PRs just removed SingletonTokenAcquisition property from MicrosoftIdentityOptions.)

microsoft-identity-web/src/Microsoft.Identity.Web/ServiceCollectionExtensions.cs

Lines 33 to 35 in 7df3679

	public static IServiceCollection AddTokenAcquisition(
	this IServiceCollection services,
	bool isTokenAcquisitionSingleton = false)