Fixed incorrect IMDS resource ID query parameter #7488
Draft
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robbie-Microsoft
requested review from
sameerag,
tnorling,
hectormmg,
peterzenz and
a team
as code owners
bgavrilMS
reviewed
Jan 2, 2025
| @@ -38,7 +38,7 @@ import { | |||
| export const ManagedIdentityUserAssignedIdQueryParameterNames = { | |||
| MANAGED_IDENTITY_CLIENT_ID: "client_id", | |||
| MANAGED_IDENTITY_OBJECT_ID: "object_id", | |||
| MANAGED_IDENTITY_RESOURCE_ID: "mi_res_id", | |||
| MANAGED_IDENTITY_RESOURCE_ID: "msi_res_id", | |||
There was a problem hiding this comment.
The bug states that this change should only be done for IMDS, not for all sources.
There was a problem hiding this comment.
Also, pls take the time to improve your tests. The fact that you make a change like this and no test breaks is sign that code coverage can be improved.
There was a problem hiding this comment.
Isn't this change desirable to more than just IMDS?
There was a problem hiding this comment.
It seems that only IMDS documents this as "msi_res_id" and the rest do not. App service does not. Not sure about the others.
There was a problem hiding this comment.
Actually, for "the others", only Machine Learning is applicable, and we assume it follows IMDS's "msi_res_id", too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7487
Tests don't need to be updated.