-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct IMDS resource ID query parameter #4911
Comments
Interesting. We (MSAL teams) were mostly referencing public docs from Question:
|
Good question, and I don't know the right answer. We would need to validate with the resource owners.
ACI is an IMDS-like endpoint, but I'm not sure if it is an actual IDMS implementation, or similar to it like with other hosting platforms. In such cases, we typically rely on the IMDS fallback as long as they adhere to the same protocol. |
Hi @christothes - do I understand correctly that Azure SDK has the same issue today? Is this blocking Azure SDK adoption of MSAL for MSI ? |
Correct - we could fix it but as we've already migrated to MSAL in preview, it wouldn't take effect until MSAL addresses it. |
All our flavors of managed identity are owned by different teams. They have sometimes imitated each other but their implementations are separate. |
|
👍 it's never been safe to assume uniformity across these APIs. They're all snowflakes.
So far as I know, only IMDS has a formal spec. Other endpoints are described less formally in their public docs, if at all, and those docs are sometimes wrong. The Azure SDK may be the best example of what works.
It's indistinguishable from IMDS at runtime. See e.g. the ACI docs. The same code can support both IMDs and ACI. I don't know any practical difference other than the resource ID parameter. |
How about we test this out in MSAL Golang, which is being worked on, and then make the changes in the other MSALs too? It will help with testing. But it will take longer to fix. CC @4gust @AndyOHart |
It appears there is another scenario that we haven't accounted for on ACI. As described in this article, for Windows containers, the normal IMDS endpoint (169.254.169.254) isn't available. In that case, the Here are some details from an issue where a customer hit this. Azure/azure-sdk-for-net#45547 (comment) |
Then we might have reached the limitation of the current Managed Identity v1 design. With the current heuristic algorithm, the existence of both |
Hi all, one of my customers is running into similar issues as they try to get managed identity in their ACI implementation. Do we have any updates / guidance please? |
Just an update on this - @4gust is testing with |
IMDS uses App Service may support Our previous understanding is to use |
Specifying an identity by resource ID doesn't work on Azure Container Instances (and maybe some other platforms) because we specify the resource ID with query parameter "mi_res_id". ACI observes only "msi_res_id", which we should prefer anyway because although IMDS observes both parameters, it documents only msi_res_id.
The text was updated successfully, but these errors were encountered: