Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAML and SAML2 Extensibility Testing: Audience #3006

Closed
wants to merge 21 commits into from

Conversation

iNinja
Copy link
Contributor

@iNinja iNinja commented Nov 14, 2024

SAML and SAML2 Extensibility Testing: Audience

  • Adjusted previous JWT audience extensibility work to match the work done on issuer extensibility testing
  • Added exception handling for the audience validation delegates on SAML and SAML2, in case an override were to throw.
  • Added extensibility tests for issuer validation to SAML and SAML2.

Note: This PR will remain in draft until the issuer one goes in due to dependencies (#2997). Once the issuer PR is merged, the modified files in this one will be simplified.

Part of #2711

…re the exception is unknown and a special error message is returned. Simplified stack trace creation
…ating the exception. Handle audience validation delegate throwing
…to a separate folder within TestUtils. Split issuer and audience validation delegates to their own files. Updated references in tests.
@iNinja iNinja changed the title Iinglese/extensibility testing audience SAML and SAML2 Extensibility Testing: Audience Nov 14, 2024
@iNinja
Copy link
Contributor Author

iNinja commented Nov 16, 2024

Re-issuing extensibility PRs with better alignment.

@iNinja iNinja closed this Nov 16, 2024
@iNinja iNinja deleted the iinglese/extensibility-testing-audience branch November 25, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant