Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAML and SAML2 Extensibility Testing: Issuer #2997

Closed
wants to merge 12 commits into from
Closed

SAML and SAML2 Extensibility Testing: Issuer #2997

wants to merge 12 commits into from

Conversation

iNinja
Copy link
Contributor

@iNinja iNinja commented Nov 12, 2024

SAML and SAML2 Extensibility Testing: Issuer

  • Adjusted JWT's issuer extensibility work to simplify the creation of the stack frames for comparison, and to assert that the stack traces are present in the generated exceptions, and they match the expectations.
  • Added exception handling for the issuer validation delegates on SAML and SAML2, in case an override were to throw.
  • Added extensibility tests for issuer validation to SAML and SAML2.

Note: This work is based on #2987 with some adjustments made to the work agreed on there.

Part of #2711

@iNinja iNinja requested a review from a team as a code owner November 12, 2024 14:05
@iNinja iNinja mentioned this pull request Nov 14, 2024
Closed
@iNinja
Copy link
Contributor Author

iNinja commented Nov 16, 2024

Re-issuing extensibility PRs with better alignment.

@iNinja iNinja closed this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iNinja