Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on Microsoft.Bcl.TimeProvider for .NET 8+ targets #2935

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

filipnavara
Copy link
Contributor

@filipnavara filipnavara commented Oct 23, 2024

Remove dependency on Microsoft.Bcl.TimeProvider for .NET 8+ targets

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • If any gains or losses in performance are possible, you've included benchmarks for your changes. More info
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

.NET 8+ includes the System.TimeProvider in product assemblies and thus doesn't need the Microsoft.Bcl.TimeProvider OOB package.

Due to authoring error in Microsoft.Bcl.TimeProvider 8.0.1 (dotnet/runtime#109163) the extra reference may cause build errors in scenarios building for Apple platforms or using PublishTrimmed=true.

@filipnavara filipnavara marked this pull request as ready for review October 23, 2024 22:06
@filipnavara filipnavara requested a review from a team as a code owner October 23, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants