-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft.Bcl.TimeProvider 8.0.1 contains incorrect linker substitution resources #109163
Comments
Tagging subscribers to this area: @dotnet/area-system-resources |
Tagging subscribers to this area: @dotnet/area-system-datetime |
... They shouldn't need that package for .NET 8+, since that's the compat package to enable |
Good point :-) I didn't realize they ship net8.0 and net9.0 assets. |
I think it would be a good idea to set the property |
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar |
Microsoft.IdentityModel.Tokens recently added a dependency on Microsoft.Bcl.TimeProvider 8.0.1 which uncovered a publishing error. The package contains Microsoft.Bcl.TimeProvider.dll for .NET 8 that contains an ILLink.Substitutions.xml resource with the following content:
There are, however, no other resources in the .dll and the script generates the following errors during publish:
This affects all the
net8.0-macos
/net8.0-ios
builds because they run ILLink as part of the build process.It seems that the 9.0.0-rc.2.24473.5 version of the package doesn't suffer from this authoring issue. Is it safe to migrate to the new version? What's the guidance for bumping the NuGet version number in transitive references? Should I suggest the Azure AD team (https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet) to bump the dependency to the 9.0.0-rc2 version? /cc @FuPingFranco
The text was updated successfully, but these errors were encountered: