Validate Issuer Using New Validation Model in Saml2SecurityTokenHandler #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' of https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet into francofung/ImplementIssuerValidationInSaml2WithNewModel
iNinja
reviewed
Oct 22, 2024
iNinja
reviewed
Oct 22, 2024
...icrosoft.IdentityModel.Tokens.Saml/Saml2/Saml2SecurityTokenHandler.ValidateToken.Internal.cs
Outdated
Show resolved
Hide resolved
iNinja
reviewed
Oct 22, 2024
...icrosoft.IdentityModel.Tokens.Saml/Saml2/Saml2SecurityTokenHandler.ValidateToken.Internal.cs
Outdated
Show resolved
Hide resolved
|
@FuPingFranco will you be addressing the comments |
|
@FuPingFranco please advise if you intend to update this, or I can make the changes. |
iNinja
approved these changes
Oct 23, 2024
src/Microsoft.IdentityModel.Tokens.Saml/Saml/SamlTokenUtilities.cs
Outdated
Show resolved
Hide resolved
kellyyangsong
approved these changes
Oct 23, 2024
…s.cs Co-authored-by: kellyyangsong <[email protected]>
westin-m
approved these changes
Oct 23, 2024
iNinja
deleted the
francofung/ImplementIssuerValidationInSaml2WithNewModel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate Issuer Using New Validation Model in Saml2SecurityTokenHandler
Description
Implements issuer validation as part of the new ValidateTokenAsync method in Saml2SecurityTokenHandler
Fixes #2883 and #2880