Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Pragma Disable Warning For New ValidateTokenAsync Method on Saml2TokenHandler #2880

Closed
FuPingFranco opened this issue Oct 7, 2024 · 1 comment · Fixed by #2929
Closed
Assignees
Labels
Internal Indicates issue was opened by the IdentityModel team

Comments

@FuPingFranco
Copy link
Contributor

Due to the TDD approach we are taking on constructing the new ValidateTokenAsync method on Saml2TokenHandler that implement our new token validation model, we introduced pragma warnings disable around methods that passed CancellationToken. We should be able to remove them once we get into async validators such as the Issuer validator.

@iNinja
Copy link
Contributor

iNinja commented Oct 22, 2024

This will be solved once #2929 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Indicates issue was opened by the IdentityModel team
Projects
None yet
2 participants