Add lock when configuration is null #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Show resolved
Hide resolved
keegan-caruso
approved these changes
Aug 14, 2024
westin-m
approved these changes
Aug 15, 2024
brentschmaltz
force-pushed
the
brentsch/RemoveSlimLock
branch
from
efa0143 to
cfa85a8
Compare
This was referenced Jan 8, 2025
keegan-caruso
pushed a commit
that referenced
this pull request
Jan 10, 2025
Further reverting the change to RequestRefresh from #2780 This is still too much of a behavioral change. RequestRefresh goes back to its historical function, signalling that the next call to GetConfigurationAsync should request data. This is incorporated with the background thread change to instead do the request as a blocking operation if from a RequestRefresh Part of #3082
keegan-caruso
added a commit
that referenced
this pull request
Jan 10, 2025
* RequestRefresh back to a signal Further reverting the change to RequestRefresh from #2780 This is still too much of a behavioral change. RequestRefresh goes back to its historical function, signalling that the next call to GetConfigurationAsync should request data. This is incorporated with the background thread change to instead do the request as a blocking operation if from a RequestRefresh Part of #3082 * Add time based testing to ConfigurationManagerTests through FakeTimeProvider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata is now updated on a background Task.
Previously updating was behind a SlimLock on every update to the metadata endpoint which resulted in a blocking call when RequestRefresh or AutomaticRefresh were called.
The lock is applied only when configuration has not been obtained, this stops the case when a number of threads startup and each thread would hit the metadata endpoint.