Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Behavioral change in ConfigurationManager #3082

Closed
keegan-caruso opened this issue Jan 8, 2025 · 0 comments · Fixed by #3083
Closed

[Bug] Behavioral change in ConfigurationManager #3082

keegan-caruso opened this issue Jan 8, 2025 · 0 comments · Fixed by #3083
Labels
Bug Product is not functioning as expected Internal Indicates issue was opened by the IdentityModel team

Comments

@keegan-caruso
Copy link
Contributor

keegan-caruso commented Jan 8, 2025 •
edited
Loading

#2780 introduced background refresh for metadata.

This is fine for automatic refresh, for RequestRefresh, the historical behavior should not change.
@keegan-caruso keegan-caruso added Bug Product is not functioning as expected Internal Indicates issue was opened by the IdentityModel team labels Jan 8, 2025
@keegan-caruso keegan-caruso mentioned this issue Jan 8, 2025
Merged
keegan-caruso pushed a commit that referenced this issue Jan 10, 2025
RequestRefresh back to a signal
931a3bf 
Further reverting the change to RequestRefresh from #2780
This is still too much of a behavioral change. RequestRefresh goes back
to its historical function, signalling that the next call to
GetConfigurationAsync should request data. This is incorporated with
the background thread change to instead do the request as a blocking
operation if from a RequestRefresh

Part of #3082
@keegan-caruso keegan-caruso mentioned this issue Jan 10, 2025
Merged
keegan-caruso added a commit that referenced this issue Jan 10, 2025
@keegan-caruso
RequestRefresh back to a signal for GetConfigurationAsync (#3087)
42b0c2c 
* RequestRefresh back to a signal

Further reverting the change to RequestRefresh from #2780
This is still too much of a behavioral change. RequestRefresh goes back
to its historical function, signalling that the next call to
GetConfigurationAsync should request data. This is incorporated with
the background thread change to instead do the request as a blocking
operation if from a RequestRefresh

Part of #3082

* Add time based testing to ConfigurationManagerTests
through FakeTimeProvider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Product is not functioning as expected Internal Indicates issue was opened by the IdentityModel team
Projects
None yet
Milestone
No milestone
1 participant
@keegan-caruso