Bash version of updateAssemblyInfo script #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mthalman Thanks for the contribution...could you target dev7 branch instead? Thx. |
|
Converted to a draft. I need to make some more changes so that this will run in Alpine Linux. |
This allows it work in BusyBox where grep doesn't have support for Perl regex syntax
keegan-caruso
approved these changes
Aug 21, 2023
jennyf19
approved these changes
Aug 21, 2023
|
Thanks @mthalman |
|
Included in preview4 release |
brentschmaltz
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Bash version of updateAssemblyInfo script * Remove dependency on xmllint tool which might not exist in environment * Replace grep with sed This allows it work in BusyBox where grep doesn't have support for Perl regex syntax
brentschmaltz
pushed a commit
that referenced
this pull request
Sep 7, 2023
* Bash version of updateAssemblyInfo script * Remove dependency on xmllint tool which might not exist in environment * Replace grep with sed This allows it work in BusyBox where grep doesn't have support for Perl regex syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defines a Bash version of the existing updateAssemblyInfo.ps1 script. Since there are already existing Bash versions of the build and test scripts, it made sense to follow that pattern here as well.
This accommodates .NET's source-build requirements which disallow the dependency on PowerShell because it's not buildable from source by Linux distros. The implementation in this script is necessary for .NET's source-build in order to set the assembly versions correctly (see dotnet/source-build#3565).