IdentityModel assemblies have incorrect assembly version

[mthalman]

When comparing assembly versions between the Microsoft SDK and the source-built SDK, the following diff showed up:

-sdk/x.y.z/DotnetTools/dotnet-user-jwts/x.y.z/tools/netx.y/any/Microsoft.IdentityModel.Abstractions.dll - 6.21.0
-sdk/x.y.z/DotnetTools/dotnet-user-jwts/x.y.z/tools/netx.y/any/Microsoft.IdentityModel.JsonWebTokens.dll - 6.21.0
-sdk/x.y.z/DotnetTools/dotnet-user-jwts/x.y.z/tools/netx.y/any/Microsoft.IdentityModel.Logging.dll - 6.21.0
-sdk/x.y.z/DotnetTools/dotnet-user-jwts/x.y.z/tools/netx.y/any/Microsoft.IdentityModel.Tokens.dll - 6.21.0
-sdk/x.y.z/DotnetTools/dotnet-user-jwts/x.y.z/tools/netx.y/any/System.IdentityModel.Tokens.Jwt.dll - 6.21.0
+sdk/x.y.z/DotnetTools/dotnet-user-jwts/x.y.z/tools/netx.y/any/Microsoft.IdentityModel.Abstractions.dll - 0.0.1
+sdk/x.y.z/DotnetTools/dotnet-user-jwts/x.y.z/tools/netx.y/any/Microsoft.IdentityModel.JsonWebTokens.dll - 0.0.1
+sdk/x.y.z/DotnetTools/dotnet-user-jwts/x.y.z/tools/netx.y/any/Microsoft.IdentityModel.Logging.dll - 0.0.1
+sdk/x.y.z/DotnetTools/dotnet-user-jwts/x.y.z/tools/netx.y/any/Microsoft.IdentityModel.Tokens.dll - 0.0.1
+sdk/x.y.z/DotnetTools/dotnet-user-jwts/x.y.z/tools/netx.y/any/System.IdentityModel.Tokens.Jwt.dll - 0.0.1

These assemblies are produced from source-build-externals. The package version is being set correctly. However, the source of the external repo is configured in such a way to default the assembly version to 0.0.1 and it must be explicitly overriden. The repo does contain a script to overwrite this file which makes use of the settings in a config file that contains the correct version. So it should just be a matter of customizing the source-build-externals build to invoke this script. This script is also called by the repo's own release pipeline.

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[mthalman]

So it should just be a matter of customizing the source-build-externals build to invoke this script.

Except it's not that simple. This script is authored in PowerShell. We can't be making use of non-source-built tools like this as part of the built logic. So really the only option is to reimplement the PowerShell script in Bash.

The other issue is that the script's logic uses git to get the current commit SHA to inject into the AssemblyInformationVersion attribute. That's not going to work in non-repo environments where the source has simply been extracted from a tarball.

[MichaelSimons]

@mthalman - should this issue remain open until the version test baseline has been updated to reflect the fix that went into IdentityModel is picked up?

[mthalman]

Sure, that's fine

[mthalman]

Builds are all passing now and assembly version comparisons are all good.