Guard logging calls to avoid unnecessary work at call site #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennyf19
reviewed
Jul 26, 2023
jennyf19
approved these changes
Jul 26, 2023
|
@stephentoub merge conflict from #2161 |
stephentoub
force-pushed
the
guardlogging
branch
from
b48eb04 to
0200ffc
Compare
Yup, thanks, fixed. I'd submitted this with the commit from that one, just deleted that first commit here with a rebase. |
|
@stephentoub looks like there are still merge conflicts? |
Not "still", but "again" :) I'll fix them again. |
Hard to keep up with you! |
brentschmaltz
approved these changes
Jul 27, 2023
stephentoub
force-pushed
the
guardlogging
branch
from
0200ffc to
9715ff1
Compare
|
Conflicts resolved. |
|
@keegan-caruso and @brentschmaltz the tests via the GitHub action is not working properly, or there is a test failure not bubbling up nicely. We will have to test this one locally for now. |
|
@jennyf19 I don't understand, when I pull this one locally the test run hangs |
That makes sense...But that test doesn't normally hang? |
Many LogHelper.Log calls are doing work at the call site, such as allocating params arrays, boxing structs, formatting strings, and so on, even when the data will be thrown away because logging (or logging for that verbosity level) isn't enabled. This adds an IsEnabled method to LogHelper and uses it at any call site where there's such work to be avoided.
stephentoub
force-pushed
the
guardlogging
branch
from
d8c137c to
5d75873
Compare
jennyf19
approved these changes
Jul 28, 2023
brentschmaltz
pushed a commit
that referenced
this pull request
Jul 28, 2023
Many LogHelper.Log calls are doing work at the call site, such as allocating params arrays, boxing structs, formatting strings, and so on, even when the data will be thrown away because logging (or logging for that verbosity level) isn't enabled. This adds an IsEnabled method to LogHelper and uses it at any call site where there's such work to be avoided.
brentschmaltz
pushed a commit
that referenced
this pull request
Jul 28, 2023
Many LogHelper.Log calls are doing work at the call site, such as allocating params arrays, boxing structs, formatting strings, and so on, even when the data will be thrown away because logging (or logging for that verbosity level) isn't enabled. This adds an IsEnabled method to LogHelper and uses it at any call site where there's such work to be avoided.
brentschmaltz
pushed a commit
that referenced
this pull request
Sep 6, 2023
Many LogHelper.Log calls are doing work at the call site, such as allocating params arrays, boxing structs, formatting strings, and so on, even when the data will be thrown away because logging (or logging for that verbosity level) isn't enabled. This adds an IsEnabled method to LogHelper and uses it at any call site where there's such work to be avoided.
brentschmaltz
pushed a commit
that referenced
this pull request
Sep 7, 2023
Many LogHelper.Log calls are doing work at the call site, such as allocating params arrays, boxing structs, formatting strings, and so on, even when the data will be thrown away because logging (or logging for that verbosity level) isn't enabled. This adds an IsEnabled method to LogHelper and uses it at any call site where there's such work to be avoided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Ignore the first commit. It is a copy of the commit from #2161, which this PR then builds on.)
Many LogHelper.Log calls are doing work at the call site, such as allocating params arrays, boxing structs, formatting strings, and so on, even when the data will be thrown away because logging (or logging for that verbosity level) isn't enabled. This adds an IsEnabled method to LogHelper and uses it at any call site where there's such work to be avoided.
Fixes #2163