Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calls to LogHelper incur cost even when logging is disabled #2163

Closed
stephentoub opened this issue Jul 26, 2023 · 1 comment
Closed

Calls to LogHelper incur cost even when logging is disabled #2163

stephentoub opened this issue Jul 26, 2023 · 1 comment
Assignees

Comments

@stephentoub
Copy link
Collaborator

Many calls to LogHelper are incurring allocation and other costs even when logging is disabled. More than half of all the calls to LogInformation, for example, pass a parameter that will cause the call site to allocate an array for the params array argument. Other call sites box value type arguments to be passed in that params array as an object. Etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants