add net8.0 target #2108
Merged
add net8.0 target #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westin-m
requested review from
brentschmaltz,
jmprieur,
jennyf19 and
keegan-caruso
src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Jun 8, 2023
jennyf19
reviewed
Jun 8, 2023
jennyf19
reviewed
Jun 8, 2023
src/Microsoft.IdentityModel.Tokens.Saml/Saml/Exceptions/SamlSecurityTokenException.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Jun 8, 2023
test/Microsoft.IdentityModel.Tokens.Tests/AsymmetricAdapterTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.IdentityModel.TestUtils/SecurityKeyCustomConverter.cs
Outdated
Show resolved
Hide resolved
No, probably not. That's about 29 more files; should this be its own PR? In reply to: 1583577448 |
|
Yes. let's do a separate PR. Please open an issue in wilson for tracking and link to the previous PR for removing the target as well. thanks! sorry to have just noticed that. In reply to: 1583577448 |
jennyf19
approved these changes
Jun 9, 2023
jmprieur
reviewed
Jun 9, 2023
src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.cs
Outdated
Show resolved
Hide resolved
westin-m
force-pushed
the
westinm/net8
branch
3 times, most recently
from
059b573 to
559b80b
Compare
add net8.0 target Put CustomKey and a custom converter for SecurityKey in TestUtils, transition aot test to net8.0
brentschmaltz
pushed a commit
that referenced
this pull request
Jul 25, 2023
add net8.0 target Put CustomKey and a custom converter for SecurityKey in TestUtils, transition aot test to net8.0
brentschmaltz
pushed a commit
that referenced
this pull request
Jul 28, 2023
add net8.0 target Put CustomKey and a custom converter for SecurityKey in TestUtils, transition aot test to net8.0
brentschmaltz
pushed a commit
that referenced
this pull request
Jul 28, 2023
add net8.0 target Put CustomKey and a custom converter for SecurityKey in TestUtils, transition aot test to net8.0
brentschmaltz
pushed a commit
that referenced
this pull request
Sep 6, 2023
add net8.0 target Put CustomKey and a custom converter for SecurityKey in TestUtils, transition aot test to net8.0
brentschmaltz
pushed a commit
that referenced
this pull request
Sep 7, 2023
add net8.0 target Put CustomKey and a custom converter for SecurityKey in TestUtils, transition aot test to net8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put CustomKey and a custom converter for SecurityKey in TestUtils, transition aot test to net8.0