Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Conditional compilation for net8.0 #2111

Closed
westin-m opened this issue Jun 9, 2023 · 1 comment · Fixed by #2122
Closed

[Feature Request] Conditional compilation for net8.0 #2111

westin-m opened this issue Jun 9, 2023 · 1 comment · Fixed by #2122
Assignees
@westin-m
Labels
Internal Indicates issue was opened by the IdentityModel team

Comments

@westin-m
Copy link
Contributor

westin-m commented Jun 9, 2023

As of #2108, net8.0 is a required build target. Add a condition to the build props that targets net8.0 if an environment variable is set, making it opt-in.
@westin-m westin-m self-assigned this Jun 9, 2023
@westin-m westin-m mentioned this issue Jun 9, 2023
Merged
@brentschmaltz brentschmaltz added the Internal Indicates issue was opened by the IdentityModel team label Jun 12, 2023
@jmprieur
Copy link
Contributor

Also, when building .NET 8:

  • Remove the reference to sourcelink when building .NET 8 (as it's included)
  • Enable the configuration binding generator (which should remove a bunch of AoT warnings): What's new in .NET 8 | Microsoft Learn
  • only emit our AoT warnings when building with .NET 8?

@westin-m westin-m linked a pull request Jun 26, 2023 that will close this issue
conditional compilation for net 8 #2122
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@westin-m westin-m

Labels
Internal Indicates issue was opened by the IdentityModel team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

conditional compilation for net 8 AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet
3 participants
@brentschmaltz @jmprieur @westin-m