Trim commit message to not include description

[Methuselah96]

Resolves #192.

I considered trimming the commit message to a certain length, but it appears that it would be hard to completely predict how long the message sent to Kudu is since the message contains more than just the commit message. It seems reasonable to just include the first line of the commit message.

[ghost]

All CLA requirements met.

[github-actions]

This PR is idle because it has been open for 14 days with no activity.

[mattnieland]

ANYONE gonna do anything about this problem and approve his PR?

[github-actions]

This PR is idle because it has been open for 14 days with no activity.

[DavidBoike]

Can someone please look at this PR? This problem is a constant annoyance.

[github-actions]

This PR is idle because it has been open for 14 days with no activity.

[DavidBoike]

@Methuselah96 is there any way I can help? I can't even see why the CI failed because it was run so long ago, and I can't trigger it to re-run. Or are you only waiting for the Azure team to look at the PR?

[DavidBoike]

I tried opening #243 with the exact same changes (npm run build was run and npm run test passes all tests) in order to see what might be in the problem with the CI, but that results in "Waiting for review: automation test needs approval to start deploying changes." so there doesn't seem to be any point in having that PR.

It seems all this PR really needs is attention.

[Methuselah96]

@DavidBoike Yeah, I'm just waiting on review, not sure what's up with the CI.

[darena-patrick]

lgtm 🎉

[shubham805]

@Methuselah96 How did you reproduce the 404 error (#192) with a long commit message?

[Methuselah96]

@shubham805 The situation where we run into this is as described here. If you want to reproduce it without squash merge, you can just include a really long multi-line commit message (that includes a one line summary and then a really long description).

[shubham805]

@Methuselah96 The PR looks good. Can you add a dummy commit just to re trigger the pr check pipelines?

[Methuselah96]

@shubham805 Done, says the workflow is awaiting approval.

[shubham805]

@Methuselah96 There were some issues in the PR check pipeline. We have updated it. Can you again add a new dummy commit, it will pick up the updated workflow file.

[Methuselah96]

@shubham805 Done, awaiting approval again.

[Methuselah96]

@shubham805 Are there plans to release this fix? Looking forward to this being resolved.

[shpraka]

@Methuselah96 this is released. Do let us know in case you find any issues.

[IGx89]

We just ran into this on v2 -- appears to maybe not be fixed for every scenario? Using a self-hosted runner. The ZIP deploy URL was 2572 characters long...

[IGx89]

Maybe the change should have been .split(/(\\r)?\\n/)[0] instead of .split(/\r?\n/)[0]? The latter doesn't work when I test it against a commit message such as "abc\nxyz\r\n123\n" (the commit message string contains the escape characters, so a newline for example is two characters: backslash and n)

[Methuselah96]

This was replaced by #271 anyway, so the code in this PR is no longer used (although I agree it's wrong).

[IGx89]

Should I submit a new issue, about 2572 characters in the URL being too long? #271 assumes that up to 8000 (+ change) characters is acceptable, which from our current experience seems inaccurate.

[Methuselah96]

Yeah, that would be great, thanks!

[IGx89]

Done: #288