Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment URL can get too long due to commit messages in url resulting in 404 error #263

Closed
alexandru-travels opened this issue Nov 10, 2022 · 2 comments

Comments

@alexandru-travels
Copy link

Just encountered a 404 using azure/webapps-deploy@v2 with the following definition:


- name: Deploy to Azure Web App
        id: deploy-to-webapp
        uses: azure/webapps-deploy@v2
        with:
          app-name: '<NAME>'
          slot-name: 'Production'
          publish-profile: ${{ MY_SUPER_DUPER_SECRET}}
          package: .
          

And it died with

##[debug][POST] https://MY_SUPER_SECRET_SITE:443/api/zipdeploy?isAsync=true&deployer=GITHUB_ZIP_DEPLOY&message=<A REALLY LONG QUERYSTRING ARGUMENT CONSTRUCTED FROM ALL THE COMMIT MESSAGES JOINED TOGETHER TO THE TUNE OF A 2917 CHARACTER LONG URL>
##[debug]Could not parse response body.
##[debug]{}
##[debug]ZIP Deploy response: {"statusCode":404,"statusMessage":"Not Found","headers":{"content-length":"103","connection":"close","content-type":"text/html","date":"Thu, 10 Nov 2022 19:56:46 GMT","server":"Microsoft-IIS/10.0","x-powered-by":"ASP.NET"},"body":"The resource you are looking for has been removed, had its name changed, or is temporarily unavailable."}
Error: Failed to deploy web package to App Service.
Error: Deployment Failed with Error: Error: Failed to deploy web package to App Service.

Any chance you guys can do a max length check on the proposed url it's about to invoke, using the commit messages strung together in the messages querystring arg, to save stupid people like me from themselves?

@FinVamp1
Copy link
Member

#192 is the same issue and there's a fix mentioned there.

@kumaraksh1
Copy link
Collaborator

PR for fixing the issue has been merged, changes will be released soon.
So I am closing this issue for now.
After a release, if issue still exists, we can always re-open it.
PR - #226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants