Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken example dapr #42

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Fix broken example dapr #42

merged 1 commit into from
Dec 18, 2023

Conversation

lonegunmanb
Copy link
Member

Describe your changes

As #41 described, we've created duplicated log analytics workspace in example/dapr, but somehow the main branch could pass the e2e test but the same issue blocked #38. This pr fixed this issue by setting var.log_analytics_workspace_name an optional variable, and pass var.log_analytics_workspace in example/dapr.

Issue number

#000

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

Copy link
Contributor

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jiaweitao001 jiaweitao001 merged commit a9ffdfd into main Dec 18, 2023
4 checks passed
@lonegunmanb lonegunmanb deleted the f-41 branch November 13, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants