Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support existing container apps environment #38

Merged
merged 16 commits into from
Dec 20, 2023

Conversation

davidkarlsen
Copy link
Contributor

@davidkarlsen davidkarlsen commented Nov 29, 2023

Describe your changes

Support existing app service environment.

Issue number

#37

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@davidkarlsen
Copy link
Contributor Author

@lonegunmanb PTAL

@davidkarlsen davidkarlsen marked this pull request as ready for review November 29, 2023 19:57
Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidkarlsen for opening this pr! Some review comments, and could you please add a corresponding example to show how to use this new variable along with a corresponding e2e test? Thanks!

main.tf Outdated Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
variables.tf Show resolved Hide resolved
@davidkarlsen
Copy link
Contributor Author

@lonegunmanb done, can we let it run to see how the test works?

Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidkarlsen for the update, some review comments but almost LGTM.

variables.tf Outdated Show resolved Hide resolved
examples/existing-env/main.tf Outdated Show resolved Hide resolved
examples/existing-env/versions.tf Outdated Show resolved Hide resolved
examples/existing-env/versions.tf Outdated Show resolved Hide resolved
@davidkarlsen
Copy link
Contributor Author

@lonegunmanb PTAL

Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidkarlsen and I must apologize for my reckless reviews. I was failed to figure out all issues one time, sorry for that.

I have a new request, we need an extra data source to provide a valid output to module's caller.

outputs.tf Outdated Show resolved Hide resolved
@davidkarlsen davidkarlsen force-pushed the feature/conditional-env branch from b05d83f to fabc05a Compare December 11, 2023 14:46
@davidkarlsen
Copy link
Contributor Author

@lonegunmanb I've rebased against current main - can we test the e2e's again?

@lonegunmanb
Copy link
Member

lonegunmanb commented Dec 15, 2023

@davidkarlsen Please wait for #40 and #39 then you're ok to rebase again, thanks!

@lonegunmanb
Copy link
Member

Hi @davidkarlsen #39 has been merged so you're good to rebase with the latest main branch and try again, thanks for your patience!

@davidkarlsen
Copy link
Contributor Author

@lonegunmanb done (PS: The branch os open for collab to merge into)

@lonegunmanb
Copy link
Member

Hi @davidkarlsen I believe that the failed e2e test should have been fixed by #42 , would you please rebase your pr with the latest main branch and try again? Sorry for your inconvenience.

@davidkarlsen
Copy link
Contributor Author

@lonegunmanb done

Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidkarlsen , LGTM!

@lonegunmanb lonegunmanb merged commit f6539f3 into Azure:main Dec 20, 2023
4 checks passed
@davidkarlsen davidkarlsen deleted the feature/conditional-env branch December 21, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants