-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pr template #429
Update pr template #429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nit about extra whitespace in the checklist instructions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
realizing there's no "approve with suggestions"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
took off auto-merge -- maybe that's approve with suggestions 😅
Co-authored-by: Glenn Musa <[email protected]>
Co-authored-by: Glenn Musa <[email protected]>
Description
Updated the PR template to remove things that are automated checks.
Issue reference
The issue this PR will close: #399
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
[ ] Code compiles or validates correctly[ ] BASH scripts have been validated usingshellcheck
[ ] All tests pass (manual and automated)[ ] Markdown files have been linted using the recommended linter. (See.vscode/extensions.json
.)