Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: avm/res/network/trafficmanagerprofile #699

Merged
merged 19 commits into from
Dec 5, 2023
Merged

feat: avm/res/network/trafficmanagerprofile #699

merged 19 commits into from
Dec 5, 2023

Conversation

lsnoddy
Copy link
Member

@lsnoddy lsnoddy commented Dec 4, 2023

Description

Migrate bicep module for trafficmanager from CARML

avm.res.network.trafficmanagerprofile

lsnoddy added 15 commits November 10, 2023 08:40
@lsnoddy
Add logicWorkflow workflow file
6ca3cfb
@lsnoddy
Merge branch 'anchor' of https://github.com/lsnoddy/bicep-registry-mo…
787633a 
…dules
@lsnoddy
Convert trafficmanager module from CARML
6c21e7d
@lsnoddy
Updated module name
f574eb6
@lsnoddy
Updated moduel name in readme
81f681e
@lsnoddy
Added endpoints to test case
e30b1b2
@lsnoddy
Fixed name prefix
28e8756
@lsnoddy
Fixed endpoint location
641f919
@lsnoddy
Merge branch 'anchor' of https://github.com/lsnoddy/bicep-registry-mo…
e42a5a9 
…dules into users/lsnoddy/avm-res-network-trafficmanagerprofile
@lsnoddy
Added endpoints to waf test case
1aa9874
@lsnoddy
Added min suppress rule for traffic manager
7ab1c6b
@lsnoddy
Added traffic manager protocol min test suppress rule
b4536a9
@lsnoddy
Removed endpoint from max test case
ec90cb7
@lsnoddy
Added enabled status to endpoints
5aec673
@lsnoddy
Enable https endpoint monitoring for waf test
d501baf
@lsnoddy lsnoddy added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Class: Resource Module 📦 This is a resource module labels Dec 4, 2023
@lsnoddy lsnoddy self-assigned this Dec 4, 2023
@lsnoddy lsnoddy requested review from a team as code owners December 4, 2023 19:49
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still and removed Needs: Triage 🔍 Maintainers need to triage still labels Dec 4, 2023
ChrisSidebotham
ChrisSidebotham requested changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@ChrisSidebotham ChrisSidebotham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you also update the CODEOWNERS file as defined here

avm/res/network/trafficmanagerprofile/tests/e2e/defaults/main.test.bicep Outdated Show resolved Hide resolved
avm/res/network/trafficmanagerprofile/tests/e2e/defaults/main.test.bicep Outdated Show resolved Hide resolved
avm/res/network/trafficmanagerprofile/main.bicep Outdated Show resolved Hide resolved
avm/res/network/trafficmanagerprofile/main.bicep Outdated Show resolved Hide resolved
@ChrisSidebotham ChrisSidebotham added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Dec 4, 2023
@lsnoddy lsnoddy mentioned this pull request Dec 4, 2023
Closed
2 tasks
@lsnoddy
Copy link
Member Author

lsnoddy commented Dec 5, 2023

Please can you also update the CODEOWNERS file as defined here

Updated CODEOWNERS file.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Dec 5, 2023
@ChrisSidebotham ChrisSidebotham self-assigned this Dec 5, 2023
ChrisSidebotham
ChrisSidebotham approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@ChrisSidebotham ChrisSidebotham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🤌

@lsnoddy lsnoddy merged commit 52a8990 into Azure:main Dec 5, 2023
13 checks passed
@lsnoddy lsnoddy deleted the users/lsnoddy/avm-res-network-trafficmanagerprofile branch December 5, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisSidebotham ChrisSidebotham ChrisSidebotham approved these changes

Assignees

@lsnoddy lsnoddy

@ChrisSidebotham ChrisSidebotham

Labels
Class: Resource Module 📦 This is a resource module Needs: Attention 👋 Reply has been added to issue, maintainer to review Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsnoddy @ChrisSidebotham