Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module Proposal]: avm/res/network/trafficmanagerprofile #181

Closed
2 tasks done
lsnoddy opened this issue Oct 12, 2023 · 8 comments
Closed
2 tasks done

[Module Proposal]: avm/res/network/trafficmanagerprofile #181

lsnoddy opened this issue Oct 12, 2023 · 8 comments
Assignees
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Status: Migrate from CARML 🚛 This item is related to a module migration from CARML Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed

Comments

@lsnoddy
Copy link
Member

lsnoddy commented Oct 12, 2023

Check for previous/existing GitHub issues/module proposals

  • I have checked for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in another project that is being evolved into AVM

  • I have checked for that this module doesn't already exist in CARML or TFVM

Terraform or Bicep?

Bicep

Module Classification?

Resource Module

Module Name

avm/res/network/trafficmanagerprofile

Module Details

Migrate existing module from CARML

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username

lsnoddy

@lsnoddy lsnoddy added Needs: Triage 🔍 Maintainers need to triage still Type: New Module Proposal 💡 A new module for AVM is being proposed labels Oct 12, 2023
@matebarabas matebarabas added Status: In Triage 🔍 Picked up for triaging by an AVM core team member Status: Migrate from CARML 🚛 This item is related to a module migration from CARML Language: Bicep 💪 This is related to the Bicep IaC language Class: Resource Module 📦 This is a resource module labels Oct 12, 2023
@matebarabas
Copy link
Contributor

Hi @lsnoddy,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team


NOTE:

  • This Module Proposal issue MUST remain open until the module is fully developed, tested and published to the relevant registry. Do NOT close the issue before the successful publication is confirmed!
  • Once the module is fully developed, tested and published to the relevant registry, and the Module Proposal issue was closed, it MUST remain closed.

@lsnoddy
Copy link
Member Author

lsnoddy commented Oct 13, 2023

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

@matebarabas
Copy link
Contributor

Hi @lsnoddy,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

We just want to ask you to double check a few important things before you start the development.

Please use the following values explicitly as provided in the module index page:

  • For your module:
    • ModuleName - to name your module
    • TelemetryIdPrefix - to be used in your module's telemetry
  • For your module's repository:
    • Repository name and folder path are defined in RepoURL
    • Create the GitHub teams defined in the ModuleOwnersGHTeam and ModuleContributorsGHTeam columns

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment, once your module is ready to be published! 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team


NOTE:

  • This Module Proposal issue MUST remain open until the module is fully developed, tested and published to the relevant registry. Do NOT close the issue before the successful publication is confirmed!
  • Once the module is fully developed, tested and published to the relevant registry, and the Module Proposal issue was closed, it MUST remain closed.

@matebarabas matebarabas moved this from Proposed to In development in AVM - Module Triage Oct 13, 2023
@matebarabas matebarabas added Status: Owners Identified 🤘 This module has its owners identified and removed Needs: Triage 🔍 Maintainers need to triage still Status: In Triage 🔍 Picked up for triaging by an AVM core team member labels Oct 13, 2023
@matebarabas
Copy link
Contributor

Please also note that since this is a migrate from CARML scenario, @prjelesi might be able to help you with the next steps. Please feel free to contact him internally.

@matebarabas matebarabas changed the title [Module Proposal]: avm-res-network-trafficmanagerprofile [Module Proposal]: avm-res-network-trafficmanagerprofile (res) (bicep) Oct 13, 2023
@matebarabas matebarabas changed the title [Module Proposal]: avm-res-network-trafficmanagerprofile (res) (bicep) [Module Proposal]: avm-res-network-trafficmanagerprofile (res) (bicep) Oct 17, 2023
@matebarabas matebarabas changed the title [Module Proposal]: avm-res-network-trafficmanagerprofile (res) (bicep) [Module Proposal]: avm/res/network/traffic-manager-profile Nov 6, 2023
@matebarabas
Copy link
Contributor

@lsnoddy,

Due to a recent change in the naming convention for AVM Bicep modules, this module is getting an updated name.

The title and description of this GH issue has been updated to reflect the name change. Please make sure you adhere to the new naming convention when publishing your module!

Please see the new naming convention in:

Please note that the Telemetry ID and name of GitHub Teams haven't changed.

If you feel uncertain about any details, please check the Bicep modules indexes.

@matebarabas matebarabas changed the title [Module Proposal]: avm/res/network/traffic-manager-profile [Module Proposal]: avm/res/network/trafficmanagerprofile Nov 6, 2023

@@lsnoddy, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

@lsnoddy
Copy link
Member Author

lsnoddy commented Dec 4, 2023

Pull request has been submitted: (Azure/bicep-registry-modules#699)

@matebarabas matebarabas added Status: In PR 👉 This is when an issue is due to be fixed in an open PR Status: Module Available 🟢 The module is published and removed Status: In PR 👉 This is when an issue is due to be fixed in an open PR labels Dec 4, 2023
@matebarabas
Copy link
Contributor

@lsnoddy, I've just noticed that this PR has already been merged. Next time, please drop a note here for faster processing! Thanks! 😉

  • Module published.
  • GitHub teams are available and assigned to their parents.
  • CODEOWNERS file updated.

Thank you for your work! I'm closing this issue now.

@github-project-automation github-project-automation bot moved this from In development to Done in AVM - Module Triage Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Status: Migrate from CARML 🚛 This item is related to a module migration from CARML Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed
Projects
Development

No branches or pull requests

2 participants