Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hardcoded version check #669 #675

Merged

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Nov 27, 2023

Description

Replaced hardcoded version check (using cognitive services) with ModulePath reference
Closes: #669

Adding a new module

  • A proposal has been submitted and approved.
  • I have included "Closes #{module_proposal_issue_number}" in the PR description.
  • I have run brm validate locally to verify the module files.
  • I have run deployment tests locally to ensure the module is deployable.

Updating an existing module

  • This is a bug fix:
    • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
    • The bug was found by the module author, and no one has opened an issue to report it yet.
  • I have run brm validate locally to verify the module files.
  • I have run deployment tests locally to ensure the module is deployable.
  • I have read the Updating an existing module section in the contributing guide and updated the version.json file properly:
    • The PR contains backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json.
    • The PR contains backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • The PR contains breaking changes, and I have bumped the MAJOR version in version.json.
  • I have updated the examples in README with the latest module version number.

@AlexanderSehr AlexanderSehr self-assigned this Nov 27, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Nov 27, 2023
@AlexanderSehr AlexanderSehr linked an issue Nov 27, 2023 that may be closed by this pull request
@AlexanderSehr AlexanderSehr marked this pull request as ready for review November 27, 2023 18:19
@AlexanderSehr AlexanderSehr requested review from a team as code owners November 27, 2023 18:19
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) November 27, 2023 18:20
@AlexanderSehr AlexanderSehr merged commit 0f10b10 into Azure:main Nov 28, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report]: Hardcoded version check
2 participants