[Bug Report]: Hardcoded version check #669
Comments
microsoft-github-policy-service
bot
added
Needs: Triage 🔍
AlexanderSehr
removed
Needs: Triage 🔍
14 tasks
14 tasks
AlexanderSehr
added a commit
that referenced
this issue
Nov 28, 2023
## Description Replaced hardcoded version check (using cognitive services) with `ModulePath` reference Closes: #669 ## Adding a new module <!--Run through the checklist if your PR adds a new module.--> - [ ] A proposal has been submitted and approved. - [ ] I have included "Closes #{module_proposal_issue_number}" in the PR description. - [ ] I have run `brm validate` locally to verify the module files. - [ ] I have run deployment tests locally to ensure the module is deployable. ## Updating an existing module <!--Run through the checklist if your PR updates an existing module.--> - [x] This is a bug fix: - [x] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] I have run `brm validate` locally to verify the module files. - [ ] I have run deployment tests locally to ensure the module is deployable. - [ ] I have read the [Updating an existing module](https://github.com/Azure/bicep-registry-modules/blob/main/CONTRIBUTING.md#updating-an-existing-module) section in the contributing guide and updated the `version.json` file properly: - [ ] The PR contains backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`. - [ ] The PR contains backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] The PR contains breaking changes, and I have bumped the MAJOR version in `version.json`. - [ ] I have updated the examples in README with the latest module version number. --------- Co-authored-by: Erika Gressi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Hey @shenglol,
I just implemented Pull Request to add the post-publish validation to the AVM pipeline. I used your pipeline step as a 1:1 reference that I just translated to Powershell.
That said, I found that you're checking 2 things
The later, however, is hardcoded to
ai/cognitiveservicesand should instead reference the ModulePath variableTo reproduce
Redundant
Code snippet
The fix should be the following:
Relevant log output
No response
The text was updated successfully, but these errors were encountered: