Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New module Issue1314 P2S VPN Gateway resource #3780

Merged
merged 36 commits into from
Dec 10, 2024
Merged
Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
8e6f8c3
Added test workflow
erschef Oct 15, 2024
c686f16
Merge branch 'Azure:main' into Issue1314-p2s-vpn-gateway
ericscheffler Oct 18, 2024
62bfbf9
feat: Add p2s-vpn-gateway module to network resources
erschef Oct 18, 2024
dcd4c8f
Merge branch 'Issue1314-p2s-vpn-gateway' of https://github.com/ericsc…
erschef Oct 18, 2024
076da88
Merge branch 'Azure:main' into Issue1314-p2s-vpn-gateway
ericscheffler Oct 21, 2024
7a921e6
Updated tests
erschef Oct 25, 2024
f1dedfe
Max tests succeeding
erschef Nov 1, 2024
8dc7ab2
feat: Enhance P2S VPN Gateway configuration with new parameters and t…
erschef Nov 8, 2024
55aa240
Forgot to run Set-AVMModule
erschef Nov 8, 2024
d1f3d5c
fix: Update descriptions for route table parameters in P2S VPN Gatewa…
erschef Nov 8, 2024
a897a16
fix: Update descriptions for route table parameters in P2S VPN Gatewa…
erschef Nov 8, 2024
86cba8c
fix: Remove P2S VPN Gateway from CODEOWNERS file
erschef Nov 8, 2024
e47fae8
fix: Add P2S VPN Gateway to CODEOWNERS file
erschef Nov 8, 2024
2a7d45c
fix: Update CODEOWNERS entry for P2S VPN Gateway module
erschef Nov 11, 2024
1251942
fix: Add associatedRouteTableName parameter to P2S VPN Gateway module…
erschef Nov 12, 2024
a95c663
fix: Update associatedRouteTableName parameter to use 'defaultRouteTa…
erschef Nov 12, 2024
d6f2b3d
fix: Reorder parameters in P2S VPN Gateway tests for consistency and …
erschef Nov 18, 2024
1b17d95
fix: Remove custom DNS servers and VPN gateway scale unit from P2S VP…
erschef Nov 18, 2024
a7cef69
Merge branch 'main' into Issue1314-p2s-vpn-gateway
ericscheffler Nov 18, 2024
d4921e2
feat: Enhance P2S VPN Gateway with static route configuration and out…
erschef Nov 25, 2024
e8e0dce
fix: Update P2S VPN Gateway test parameters to use tags for environme…
erschef Nov 25, 2024
290186c
fix: Remove lock configuration and add tags for environment and role …
erschef Nov 25, 2024
f40e2f2
fix: Update P2S VPN Gateway parameters to make location optional and …
erschef Nov 25, 2024
e82865b
fix: Update vpnClientAddressPoolAddressPrefixes parameter to be optio…
erschef Nov 25, 2024
5381853
feat: Add optional static route configuration for P2S VPN Gateway
erschef Nov 25, 2024
d404797
fix: Update output for Azure Firewall private IP to use hubIPAddresse…
erschef Nov 25, 2024
4365765
fix: Add dependency on hubRouteTable for VPNRouteMap and clean up unu…
erschef Nov 27, 2024
218ba14
fix: Update p2SConnectionConfigurationsName to remove suffix and clea…
erschef Nov 27, 2024
a0cdc9c
fix: Comment out unused vpnClientAddressPoolAddressPrefixes in Bicep …
erschef Nov 27, 2024
e9d6164
fix: Update p2SConnectionConfigurationsName and vpnServerConfiguratio…
erschef Dec 2, 2024
6bb0026
fix: Update vpnServerConfigurationResourceId to be optional in README…
erschef Dec 2, 2024
3fd2899
fix: Remove unused vnetRoutesStaticRoutes from README and test files
erschef Dec 5, 2024
8d42cc3
fix: Update serviceShort parameter to use 'npvgmin' in Bicep test files
erschef Dec 6, 2024
bd38a0c
Merge branch 'main' into Issue1314-p2s-vpn-gateway
ericscheffler Dec 6, 2024
cee5d3e
fix: Update VPN gateway names and serviceShort parameters in README a…
erschef Dec 10, 2024
d6542ae
Merge branch 'main' into Issue1314-p2s-vpn-gateway
ericscheffler Dec 10, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@
/avm/res/network/network-manager/ @Azure/avm-res-network-networkmanager-module-owners-bicep @Azure/avm-module-reviewers-bicep
/avm/res/network/network-security-group/ @Azure/avm-res-network-networksecuritygroup-module-owners-bicep @Azure/avm-module-reviewers-bicep
/avm/res/network/network-watcher/ @Azure/avm-res-network-networkwatcher-module-owners-bicep @Azure/avm-module-reviewers-bicep
/avm/res/network/p2s-vpn-gateway/ @Azure/avm-res-network-p2svpngateway-module-owners-bicep @Azure/avm-module-reviewers-bicep
/avm/res/network/private-dns-zone/ @Azure/avm-res-network-privatednszone-module-owners-bicep @Azure/avm-module-reviewers-bicep
/avm/res/network/private-endpoint/ @Azure/avm-res-network-privateendpoint-module-owners-bicep @Azure/avm-module-reviewers-bicep
/avm/res/network/private-link-service/ @Azure/avm-res-network-privatelinkservice-module-owners-bicep @Azure/avm-module-reviewers-bicep
Expand Down
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/avm_module_issue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ body:
- "avm/res/network/network-manager"
- "avm/res/network/network-security-group"
- "avm/res/network/network-watcher"
- "avm/res/network/p2s-vpn-gateway"
- "avm/res/network/private-dns-zone"
- "avm/res/network/private-endpoint"
- "avm/res/network/private-link-service"
Expand Down
88 changes: 88 additions & 0 deletions .github/workflows/avm.res.network.p2s-vpn-gateway.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
name: "avm.res.network.p2s-vpn-gateway"

on:
workflow_dispatch:
inputs:
staticValidation:
type: boolean
description: "Execute static validation"
required: false
default: true
deploymentValidation:
type: boolean
description: "Execute deployment validation"
required: false
default: true
removeDeployment:
type: boolean
description: "Remove deployed module"
required: false
default: true
customLocation:
type: string
description: "Default location overwrite (e.g., eastus)"
required: false
push:
branches:
- main
paths:
- ".github/actions/templates/avm-**"
- ".github/workflows/avm.template.module.yml"
- ".github/workflows/avm.res.network.p2s-vpn-gateway.yml"
- "avm/res/network/p2s-vpn-gateway/**"
- "avm/utilities/pipelines/**"
- "!avm/utilities/pipelines/platform/**"
- "!*/**/README.md"

env:
modulePath: "avm/res/network/p2s-vpn-gateway"
workflowPath: ".github/workflows/avm.res.network.p2s-vpn-gateway.yml"

concurrency:
group: ${{ github.workflow }}

jobs:
###########################
# Initialize pipeline #
###########################
job_initialize_pipeline:
runs-on: ubuntu-latest
name: "Initialize pipeline"
steps:
- name: "Checkout"
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: "Set input parameters to output variables"
id: get-workflow-param
uses: ./.github/actions/templates/avm-getWorkflowInput
with:
workflowPath: "${{ env.workflowPath}}"
- name: "Get module test file paths"
id: get-module-test-file-paths
uses: ./.github/actions/templates/avm-getModuleTestFiles
with:
modulePath: "${{ env.modulePath }}"
outputs:
workflowInput: ${{ steps.get-workflow-param.outputs.workflowInput }}
moduleTestFilePaths: ${{ steps.get-module-test-file-paths.outputs.moduleTestFilePaths }}
psRuleModuleTestFilePaths: ${{ steps.get-module-test-file-paths.outputs.psRuleModuleTestFilePaths }}
modulePath: "${{ env.modulePath }}"

##############################
# Call reusable workflow #
##############################
call-workflow-passing-data:
name: "Run"
permissions:
id-token: write # For OIDC
contents: write # For release tags
needs:
- job_initialize_pipeline
uses: ./.github/workflows/avm.template.module.yml
with:
workflowInput: "${{ needs.job_initialize_pipeline.outputs.workflowInput }}"
moduleTestFilePaths: "${{ needs.job_initialize_pipeline.outputs.moduleTestFilePaths }}"
psRuleModuleTestFilePaths: "${{ needs.job_initialize_pipeline.outputs.psRuleModuleTestFilePaths }}"
modulePath: "${{ needs.job_initialize_pipeline.outputs.modulePath}}"
secrets: inherit
Loading