-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New module Issue1314 P2S VPN Gateway resource #3780
feat: New module Issue1314 P2S VPN Gateway resource #3780
Conversation
This commit adds the p2s-vpn-gateway module to the network resources in the avm/res/network directory. The module allows for the deployment of a Virtual Hub P2S Gateway. It includes the necessary Bicep files, tests, and dependencies.
…heffler/bicep-registry-modules into Issue1314-p2s-vpn-gateway
…ble' in P2S VPN Gateway module and tests
Hey @ericscheffler , Firstly, thanks for your work on this PR! We have made some changes to the AVM CI, detailed below, which means we need you to update your fork to pull in these latest changes and re-run your tests to show they still are passing prior to approving and merging this PR, as we don't and it fails once merged the publishing of your module will fail and will be blocked going forward until the test pass again via additional PRs. Changes to CI That Have Been Made That You Need To Take Action On
Any questions reach out to the AVM Core Team by tagging us in your PR here or internally via Teams Thanks Jack (AVM Core Team) |
Converted to draft, troubleshooting new issues with WAF test following recent CI/CD changes |
Updated & tests succeeding, marking as Ready for review |
avm/res/network/p2s-vpn-gateway/tests/e2e/waf-aligned/main.test.bicep
Outdated
Show resolved
Hide resolved
…put for Azure Firewall private IP
…in P2S VPN Gateway module
…ensure p2SConnectionConfigurationsName is required
…nal in documentation and Bicep template
…sed static routes in tests
…n up unused static routes in README
…nResourceId to be optional in Bicep files
…, Bicep, and JSON files
Description
This PR contains a new AVM resource for the Microsoft.Network/p2svpnGateways resource provider, which builds a P2S VPN Gateway within a VWAN Virtual Hub. This resource requires a Virtual WAN and Virtual Hub, as well as a VPN Server Configuration to deploy successfully.
Closes #1314
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.