Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pattern modules for policy exemptions #3458

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

oZakari
Copy link
Contributor

@oZakari oZakari commented Oct 8, 2024

Description

Adds the pattern modules for Policy Exemptions

Closes Azure/Azure-Verified-Modules#1735

Pipeline Reference

Pipeline
avm.ptn.authorization.policy-exemption

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@oZakari oZakari changed the title Initial ptn modules for policy exemptions feat: Pattern modules for policy exemptions Oct 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Needs: Triage 🔍 Maintainers need to triage still labels Oct 8, 2024
@oZakari oZakari marked this pull request as ready for review October 16, 2024 02:45
@oZakari oZakari requested review from a team as code owners October 16, 2024 02:45
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Oct 16, 2024
@oZakari
Copy link
Contributor Author

oZakari commented Oct 16, 2024

Hi team, I assume the telemetry errors and the module identifier errors are related to the directory structure for this pattern module (similar to the ALZ Policy Assignments Pattern module) and this file? Anything I need to do on my side?

@oZakari
Copy link
Contributor Author

oZakari commented Oct 24, 2024

Hi team, I assume the telemetry errors and the module identifier errors are related to the directory structure for this pattern module (similar to the ALZ Policy Assignments Pattern module) and this file? Anything I need to do on my side?

Hi @Azure/avm-core-team, any update on this one?

@AlexanderSehr
Copy link
Contributor

Hey @oZakari,
sorry has been a busy week. Will try to squeeze the review in

@@ -6,6 +6,7 @@
/avm/ptn/aca-lza/hosting-environment/ @Azure/avm-ptn-acalza-hostingenvironment-module-owners-bicep @Azure/avm-module-reviewers-bicep
/avm/ptn/ai-platform/baseline/ @Azure/avm-ptn-aiplatform-baseline-module-owners-bicep @Azure/avm-module-reviewers-bicep
/avm/ptn/authorization/policy-assignment/ @Azure/avm-ptn-authorization-policyassignment-module-owners-bicep @Azure/avm-module-reviewers-bicep
/avm/ptn/authorization/policy-exemption/ @Azure/avm-ptn-authorization-policy-exemption-module-owners-bicep @Azure/avm-module-reviewers-bicep
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either the team is not created or not yet approved in the hierachy (ref)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, must be that it hasn't been approved yet then as it exists here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @oZakari, please don't resolve a comment unless it's a code suggestion 😉 Makes re-reviews a bit harder.
In this case this must remain a blocking comment until the group was approved. It could lead to issues if we merge the module before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping as tests are still failing for group approval. @matebarabas

@oZakari
Copy link
Contributor Author

oZakari commented Oct 25, 2024

Hey @oZakari, sorry has been a busy week. Will try to squeeze the review in

No worries at all, @AlexanderSehr! Thank you for taking the time to review it—I just wanted to make sure it was on your radar. Really appreciate it! 😊

@eriqua eriqua added Class: Pattern Module 📦 This is a pattern module and removed Needs: Triage 🔍 Maintainers need to triage still labels Oct 27, 2024
@jtracey93
Copy link
Contributor

Hey @oZakari ,

Firstly, thanks for your work on this PR!

We have made some changes to the AVM CI, detailed below, which means we need you to update your fork to pull in these latest changes and re-run your tests to show they still are passing prior to approving and merging this PR, as we don't and it fails once merged the publishing of your module will fail and will be blocked going forward until the test pass again via additional PRs.

Changes to CI That Have Been Made That You Need To Take Action On

Any questions reach out to the AVM Core Team by tagging us in your PR here or internally via Teams

Thanks

Jack (AVM Core Team)

@oZakari
Copy link
Contributor Author

oZakari commented Nov 18, 2024

Hey @oZakari ,

Firstly, thanks for your work on this PR!

We have made some changes to the AVM CI, detailed below, which means we need you to update your fork to pull in these latest changes and re-run your tests to show they still are passing prior to approving and merging this PR, as we don't and it fails once merged the publishing of your module will fail and will be blocked going forward until the test pass again via additional PRs.

Changes to CI That Have Been Made That You Need To Take Action On

Any questions reach out to the AVM Core Team by tagging us in your PR here or internally via Teams

Thanks

Jack (AVM Core Team)

Hey @oZakari ,

Firstly, thanks for your work on this PR!

We have made some changes to the AVM CI, detailed below, which means we need you to update your fork to pull in these latest changes and re-run your tests to show they still are passing prior to approving and merging this PR, as we don't and it fails once merged the publishing of your module will fail and will be blocked going forward until the test pass again via additional PRs.

Changes to CI That Have Been Made That You Need To Take Action On

Any questions reach out to the AVM Core Team by tagging us in your PR here or internally via Teams

Thanks

Jack (AVM Core Team)

Thanks, my branch has been updated.

@oZakari
Copy link
Contributor Author

oZakari commented Dec 13, 2024

Hey @AlexanderSehr, should be good for you to review now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Pattern Module 📦 This is a pattern module Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Module Proposal]: avm/ptn/authorization/policy-exemption
5 participants