-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Pattern modules for policy exemptions #3458
base: main
Are you sure you want to change the base?
Conversation
…into avm-authorization-policyexemptions
…into avm-authorization-policyexemptions
Hi team, I assume the telemetry errors and the module identifier errors are related to the directory structure for this pattern module (similar to the ALZ Policy Assignments Pattern module) and this file? Anything I need to do on my side? |
Hi @Azure/avm-core-team, any update on this one? |
Hey @oZakari, |
.github/CODEOWNERS
Outdated
@@ -6,6 +6,7 @@ | |||
/avm/ptn/aca-lza/hosting-environment/ @Azure/avm-ptn-acalza-hostingenvironment-module-owners-bicep @Azure/avm-module-reviewers-bicep | |||
/avm/ptn/ai-platform/baseline/ @Azure/avm-ptn-aiplatform-baseline-module-owners-bicep @Azure/avm-module-reviewers-bicep | |||
/avm/ptn/authorization/policy-assignment/ @Azure/avm-ptn-authorization-policyassignment-module-owners-bicep @Azure/avm-module-reviewers-bicep | |||
/avm/ptn/authorization/policy-exemption/ @Azure/avm-ptn-authorization-policy-exemption-module-owners-bicep @Azure/avm-module-reviewers-bicep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either the team is not created or not yet approved in the hierachy (ref)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, must be that it hasn't been approved yet then as it exists here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @oZakari, please don't resolve a comment unless it's a code suggestion 😉 Makes re-reviews a bit harder.
In this case this must remain a blocking comment until the group was approved. It could lead to issues if we merge the module before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping as tests are still failing for group approval. @matebarabas
avm/ptn/authorization/policy-exemption/tests/e2e/mg.defaults/main.test.bicep
Show resolved
Hide resolved
…into avm-authorization-policyexemptions
No worries at all, @AlexanderSehr! Thank you for taking the time to review it—I just wanted to make sure it was on your radar. Really appreciate it! 😊 |
…om/oZakari/bicep-registry-modules into avm-authorization-policyexemptions
…into avm-authorization-policyexemptions
Hey @oZakari , Firstly, thanks for your work on this PR! We have made some changes to the AVM CI, detailed below, which means we need you to update your fork to pull in these latest changes and re-run your tests to show they still are passing prior to approving and merging this PR, as we don't and it fails once merged the publishing of your module will fail and will be blocked going forward until the test pass again via additional PRs. Changes to CI That Have Been Made That You Need To Take Action On
Any questions reach out to the AVM Core Team by tagging us in your PR here or internally via Teams Thanks Jack (AVM Core Team) |
…into avm-authorization-policyexemptions
…om/oZakari/bicep-registry-modules into avm-authorization-policyexemptions
Thanks, my branch has been updated. |
…into avm-authorization-policyexemptions
…om/oZakari/bicep-registry-modules into avm-authorization-policyexemptions
…into avm-authorization-policyexemptions
…into avm-authorization-policyexemptions
Hey @AlexanderSehr, should be good for you to review now. Thanks! |
Description
Adds the pattern modules for Policy Exemptions
Closes Azure/Azure-Verified-Modules#1735
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.