Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module Proposal]: avm/ptn/authorization/resource-group-policy-exemption #1421

Closed
2 tasks done
oZakari opened this issue Sep 20, 2024 · 5 comments
Closed
2 tasks done
Assignees
Labels
Class: Pattern Module 📦 This is a pattern module Language: Bicep 💪 This is related to the Bicep IaC language Needs: Attention 👋 Reply has been added to issue, maintainer to review Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed

Comments

@oZakari
Copy link
Contributor

oZakari commented Sep 20, 2024

Check for previous/existing GitHub issues/module proposals

  • I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

  • I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?

Bicep

Module Classification?

Pattern Module

Module Name

avm/ptn/authorization/resource-group-policy-exemption

Module Details

Create pattern module to allow the deployment of policy exemption at a resource group scope

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

oZakari

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

@oZakari oZakari added Needs: Triage 🔍 Maintainers need to triage still Type: New Module Proposal 💡 A new module for AVM is being proposed labels Sep 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Language: Bicep 💪 This is related to the Bicep IaC language label Sep 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Owners Identified 🤘 This module has its owners identified label Sep 20, 2024
@matebarabas matebarabas added Status: In Triage 🔍 Picked up for triaging by an AVM core team member Class: Pattern Module 📦 This is a pattern module labels Sep 24, 2024
@matebarabas
Copy link
Contributor

Hi @oZakari,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Sep 24, 2024
@oZakari
Copy link
Contributor Author

oZakari commented Sep 27, 2024

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Sep 27, 2024
@matebarabas
Copy link
Contributor

Hi @oZakari,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

  • For your module:
    • ModuleName - for naming your module
    • TelemetryIdPrefix - for your module's telemetry
  • For your module's repository:
    • Repo name and folder path are defined in RepoURL
    • Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
    • Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

@matebarabas matebarabas removed Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Triage 🔍 Maintainers need to triage still Status: In Triage 🔍 Picked up for triaging by an AVM core team member labels Sep 27, 2024
@matebarabas matebarabas moved this from Proposed to In development in AVM - Module Triage Sep 27, 2024
@oZakari oZakari moved this from In development to In Review in AVM - Module Triage Oct 16, 2024
@matebarabas matebarabas added the Status: In PR 👉 This is when an issue is due to be fixed in an open PR label Oct 19, 2024

Important

@oZakari, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

Tip

To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Nov 9, 2024
@oZakari oZakari closed this as not planned Won't fix, can't repro, duplicate, stale Nov 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Status: In PR 👉 This is when an issue is due to be fixed in an open PR label Nov 27, 2024
@matebarabas
Copy link
Contributor

For the record: this issue was closed, as instead of releasing 3 policy exemption modules with distinct scopes (i.e., management group, subscription and resource group level), a single, multi-scope module will be developed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Pattern Module 📦 This is a pattern module Language: Bicep 💪 This is related to the Bicep IaC language Needs: Attention 👋 Reply has been added to issue, maintainer to review Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed
Projects
Archived in project
Development

No branches or pull requests

2 participants