Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated module name from avm/ptn/azd/container-apps to avm/ptn/azd/container-apps-stack #3452

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

NanaXiong00
Copy link
Contributor

Description

avm/ptn/azd/container-apps => avm/ptn/azd/container-apps-stack

Pipeline Reference

Pipeline
avm.ptn.azd.container-apps-stack

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@jongio for notification.

@NanaXiong00 NanaXiong00 requested review from a team as code owners October 8, 2024 10:57
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Oct 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Oct 8, 2024
@v-xuto
Copy link
Member

v-xuto commented Oct 9, 2024

@AlexanderSehr Could you help review this PR?

@AlexanderSehr
Copy link
Contributor

@AlexanderSehr Could you help review this PR?

As this so happens I had a PR open for quite a long time that was unfortunately never reviewed by the module owner :D (ref). I'll compare this one with the other and if I don't find anything to change I'll approve this one and close the other. Thanks @v-xuto

@AlexanderSehr AlexanderSehr merged commit fef4720 into Azure:main Oct 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants