Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add new ptn modules avm/ptn/azd/acr-container-app #3234

Merged
merged 12 commits into from
Oct 11, 2024
Merged

feat: Add new ptn modules avm/ptn/azd/acr-container-app #3234

merged 12 commits into from
Oct 11, 2024

Conversation

NanaXiong00
Copy link
Contributor

@NanaXiong00 NanaXiong00 commented Sep 9, 2024 •
edited
Loading

Description

Fixes Azure/Azure-Verified-Modules#1221

Pipeline Reference

Pipeline
avm.ptn.azd.acr-container-app

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@jongio for notification.

@NanaXiong00
Create ptn module container-app
7681f6d 
update CODEWONERS file

update avm_module_issue.yml

update test name

update module name

add dependence

update userAssignedResourceIds

fix psrule

add depandence

update param

add params

update param type

Add empty judgment

update test file

delete test params
@NanaXiong00 NanaXiong00 requested review from a team as code owners September 9, 2024 10:18
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Sep 9, 2024
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Sep 9, 2024
@NanaXiong00
Copy link
Contributor Author

@AlexanderSehr I have updated based on your comments, please re-review.

AlexanderSehr
AlexanderSehr previously approved these changes Sep 10, 2024
View reviewed changes
@NanaXiong00 NanaXiong00 mentioned this pull request Sep 13, 2024
Merged
11 tasks
@AlexanderSehr AlexanderSehr mentioned this pull request Sep 13, 2024
Closed
8 tasks
@matebarabas matebarabas changed the title feat: Add new ptn modules azd/container-app feat: Add new ptn modules avm/ptn/azd/container-app Sep 18, 2024
@eriqua eriqua added Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author AZD 🧑‍💻 These modules are requested/used by the AZD team. labels Sep 27, 2024
@ReneHezser
Copy link
Contributor

ReneHezser commented Oct 4, 2024 •
edited
Loading

@NanaXiong00
We have added examples for Bicep parameter files to the Readme. This has been applied to all published modules but needs to be done for PRs as well. Can you please update your branch and run the Set-AVMModule utility as detailed here. It is required for the validation pipeline to succeed and the contribution to be published.

Please reach out if any support is needed.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Oct 4, 2024
@matebarabas matebarabas changed the title feat: Add new ptn modules avm/ptn/azd/container-app feat: Add new ptn modules avm/ptn/azd/acr-container-app Oct 7, 2024
@matebarabas matebarabas mentioned this pull request Oct 7, 2024
Closed
2 tasks
@matebarabas matebarabas mentioned this pull request Oct 7, 2024
Closed
2 tasks
@NanaXiong00 NanaXiong00 closed this Oct 8, 2024
@NanaXiong00 NanaXiong00 deleted the ptn/azd/container-app branch October 8, 2024 07:47
@NanaXiong00 NanaXiong00 restored the ptn/azd/container-app branch October 8, 2024 08:02
@NanaXiong00 NanaXiong00 reopened this Oct 8, 2024
@NanaXiong00
Copy link
Contributor Author

NanaXiong00 commented Oct 8, 2024 •
edited
Loading

@AlexanderSehr, @wbreza and @matebarabas The module avm/ptn/azd/container-app has been renamed to avm/ptn/azd/acr-container-app in the current PR. Please re-review.
Besides, a new PR(#3452) has been created, renamed the avm/ptn/azd/container-apps module to avm/ptn/azd/container-apps-stack. Please review.

@NanaXiong00
Copy link
Contributor Author

@ReneHezser I have updated branch and run the Set-AVMModule utility, please review.

@eriqua eriqua added Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author and removed Needs: Triage 🔍 Maintainers need to triage still Needs: Attention 👋 Reply has been added to issue, maintainer to review labels Oct 10, 2024
AlexanderSehr
AlexanderSehr approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Off we go @NanaXiong00, thank you for the great work 💪

@AlexanderSehr AlexanderSehr merged commit b03a1a7 into Azure:main Oct 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-xuto v-xuto v-xuto left review comments

@eriqua eriqua eriqua left review comments

@matebarabas matebarabas matebarabas left review comments

@wbreza wbreza wbreza left review comments

@jongio jongio jongio left review comments

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@AlexanderSehr AlexanderSehr

@NanaXiong00 NanaXiong00

Labels
AZD 🧑‍💻 These modules are requested/used by the AZD team. Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Module Proposal]: avm/ptn/azd/acr-container-app
8 participants
@NanaXiong00 @ReneHezser @jongio @AlexanderSehr @wbreza @matebarabas @eriqua @v-xuto