Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various fixes on VM #3116

Merged
merged 15 commits into from
Aug 30, 2024
Merged

fix: various fixes on VM #3116

merged 15 commits into from
Aug 30, 2024

Conversation

rahalan
Copy link
Contributor

@rahalan rahalan commented Aug 29, 2024

fixes:

successfull run (except NVidia test due to MCPS restrictions): avm.res.compute.virtual-machine

@rahalan rahalan added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working Class: Resource Module 📦 This is a resource module labels Aug 29, 2024
@rahalan rahalan self-assigned this Aug 29, 2024
@rahalan rahalan requested review from a team as code owners August 29, 2024 12:22

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Aug 29, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Triage 🔍 Maintainers need to triage still label Aug 29, 2024
@rahalan rahalan linked an issue Aug 29, 2024 that may be closed by this pull request
1 task
@rahalan rahalan marked this pull request as draft August 29, 2024 12:59
@rahalan rahalan marked this pull request as ready for review August 29, 2024 13:06
@rahalan rahalan marked this pull request as draft August 29, 2024 13:18
@rahalan rahalan marked this pull request as ready for review August 29, 2024 13:19
@rahalan rahalan marked this pull request as draft August 29, 2024 13:21
@rahalan rahalan marked this pull request as ready for review August 29, 2024 13:47
@rahalan rahalan enabled auto-merge (squash) August 29, 2024 13:48
@rahalan rahalan marked this pull request as draft August 29, 2024 13:49
auto-merge was automatically disabled August 29, 2024 13:49

Pull request was converted to draft

@rahalan rahalan marked this pull request as ready for review August 29, 2024 13:57
@rahalan rahalan enabled auto-merge (squash) August 29, 2024 13:57
@rahalan rahalan merged commit 604beb8 into Azure:main Aug 30, 2024
4 checks passed
@rahalan rahalan deleted the users/rahalan/VMbugfixes branch September 5, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: avm/res/compute/virtual-machine AMA support
2 participants