Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AVM Module Issue]: avm/res/compute/virtual-machine AMA support #2843

Closed
1 task done
jikuja opened this issue Jul 24, 2024 · 4 comments · Fixed by #3116
Closed
1 task done

[AVM Module Issue]: avm/res/compute/virtual-machine AMA support #2843

jikuja opened this issue Jul 24, 2024 · 4 comments · Fixed by #3116
Assignees
@rahalan
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working

Comments

@jikuja
Copy link

jikuja commented Jul 24, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/compute/virtual-machine

(Optional) Module Version

No response

Description

Current virtual machine resource template MMA support is implemented by changing extension name, publisher and type properties. This approach is missing:

  • Data Collection Rules(DCR)
  • Data Collection Rule association(DCRA)

Also current implementation is setting workspaceKey as protectedSettings even LAW linkage is done by DCR.

Template documentation does not mention anything about DCRs and DCRAs.

The Fix

  • Resource template should not use inputs that are for legacy MMA extension
  • It should be possible to pass multiple DCRA configuration as parameters

Security

I was wondering if this should be security-typed issue because falase sense of security...

(Optional) Correlation Id

No response
@jikuja jikuja added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jul 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: Bug 🐛 Something isn't working label Jul 24, 2024
@avm-team-linter AVM Team Linter
Copy link

@jikuja, thanks for submitting this issue for the avm/res/compute/virtual-machine module!

Important

A member of the @Azure/avm-res-compute-virtualmachine-module-owners-bicep or @Azure/avm-res-compute-virtualmachine-module-contributors-bicep team will review it soon!

@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Jul 24, 2024
@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Jul 24, 2024
@jikuja jikuja mentioned this issue Jul 24, 2024
Closed
1 task
@jikuja
Copy link
Author

jikuja commented Jul 29, 2024

Misleading change happened ealier on ResourceModules -repository: https://github.com/Azure/ResourceModules/pull/3938/files#diff-ea64a3e8858890c0add5dac6bdb2ae82d6a78761b4db0e231a84f632d30cb153L571-L585

@rahalan
Copy link
Contributor

rahalan commented Aug 1, 2024

@jikuja thanks for bringing it up. I will investigate.

@rahalan rahalan removed the Needs: Triage 🔍 Maintainers need to triage still label Aug 1, 2024
@rahalan rahalan mentioned this issue Aug 29, 2024
Merged
@rahalan rahalan linked a pull request Aug 29, 2024 that will close this issue
fix: various fixes on VM #3116
Merged
@rahalan rahalan moved this from Needs: Triage to In Development in AVM - Module Issues Aug 29, 2024
@rahalan
Copy link
Contributor

rahalan commented Aug 29, 2024

@jikuja will be fixed in PR #3116

rahalan added a commit that referenced this issue Aug 30, 2024
@rahalan @AlexanderSehr
fix: various fixes on VM (#3116)
604beb8 
fixes:
- #2843 
- error in readme fixed (missing dot in parameter description)
- enableHotpatch is disabled by default
- allowed types added to securityType

successfull run (except NVidia test due to MCPS restrictions):
[![avm.res.compute.virtual-machine](https://github.com/rahalan/bicep-registry-modules/actions/workflows/avm.res.compute.virtual-machine.yml/badge.svg)](https://github.com/rahalan/bicep-registry-modules/actions/workflows/avm.res.compute.virtual-machine.yml)

---------

Co-authored-by: Alexander Sehr <[email protected]>
@github-project-automation github-project-automation bot moved this from In Development to Done in AVM - Module Issues Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahalan rahalan

Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
AVM - Module Issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: various fixes on VM rahalan/bicep-registry-modules
2 participants
@jikuja @rahalan