Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avm/res/dev-test-lab/lab Enable Artifact repo Security Token on the parent module & uplift to leverage UDTs #3102

Merged
merged 18 commits into from
Aug 27, 2024

Conversation

ahmadabdalla
Copy link
Contributor

@ahmadabdalla ahmadabdalla commented Aug 27, 2024

Description

Closes #3056

  • Enable securityToken from the parent module for artifacts authentication.

Module deployment history View
image

Child Module deployment history View
image

Code view
image

  • Uplift module to support User Defined Types (UDT)
  • Leverage the @export feature of bicep to reduce code duplication for UDT.
  • Uplift module to v0.3
  • Simplified events parameters.

Pipeline Reference

Pipeline
avm.res.dev-test-lab.lab

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

chore: Update artifact source parameters in dev-test-lab/lab/artifactsource/main.json

fix: Fix broken pipeline in dev-test-lab/lab/tests/e2e/max/main.test.bicep

chore: Update npm dependency to latest stable version

chore: Update documentation for avm/res/search/search-service module

feat: Add support for additional parameters in avm/res/net-app/net-app-account module

fix: Fix telemetry identifier in avm/res/network/front-door-web-application-firewall-policy module

feat: Add support for Peer Encryption in avm/res/app/managed-environment module

feat: Add ability to deploy function app on container apps in avm/res/web/site module

feat: Add forecasted e2e test for avm/res/consumption/budget module
…ecurrence, hourlyRecurrence, and weeklyRecurrence optional
The DevTest Lab Schedule module description has been updated to use line breaks instead of carriage returns for better readability.
@ahmadabdalla ahmadabdalla self-assigned this Aug 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Aug 27, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Aug 27, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@ahmadabdalla ahmadabdalla marked this pull request as ready for review August 27, 2024 01:24
@ahmadabdalla ahmadabdalla requested review from a team as code owners August 27, 2024 01:24
@ahmadabdalla ahmadabdalla changed the title feat: avm/res/dev-test-lab/lab Enable Artifact repo Security Token on the parent module for DevTest Lab and uplift module to leverage UDTs feat: avm/res/dev-test-lab/lab Enable Artifact repo Security Token on the parent module & uplift to leverage UDTs Aug 27, 2024
@AlexanderSehr AlexanderSehr merged commit cabac47 into Azure:main Aug 27, 2024
4 checks passed
@ahmadabdalla ahmadabdalla deleted the users/ahmad/3056_DTL branch September 3, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: DevTestLab missing parameter
2 participants